Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed deprecated Intl component usage #11794

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Fixed deprecated Intl component usage #11794

merged 1 commit into from
Dec 29, 2020

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Sep 2, 2020

Q A
Branch? 1.8
Bug fix? yes(?)
New feature? no
BC breaks? no
Deprecations? no
Related tickets related #10928
License MIT

@stloyd stloyd requested a review from a team as a code owner September 2, 2020 07:45
@stloyd stloyd force-pushed the bugfix/intl-depr branch 2 times, most recently from 6c06a34 to 3b808b8 Compare September 7, 2020 12:57
@stloyd
Copy link
Contributor Author

stloyd commented Sep 9, 2020

@pamil @lchrusciel Friendly ping 😂

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Dec 25, 2020
@stloyd
Copy link
Contributor Author

stloyd commented Dec 26, 2020

This is still valid...

@stale stale bot removed the Stale Issues and PRs with no recent activity, about to be closed soon. label Dec 26, 2020
@stloyd stloyd force-pushed the bugfix/intl-depr branch 2 times, most recently from b9fa28f to 49926ea Compare December 28, 2020 10:27
@stloyd
Copy link
Contributor Author

stloyd commented Dec 28, 2020

@pamil @Tomanhez @lchrusciel Can we get this one merged?

@Zales0123 Zales0123 added the DX Issues and PRs aimed at improving Developer eXperience. label Dec 29, 2020
@lchrusciel lchrusciel added the Dependencies Pull requests that update a dependency file label Dec 29, 2020
@lchrusciel lchrusciel merged commit f4ab9db into Sylius:1.8 Dec 29, 2020
@lchrusciel
Copy link
Member

Thank you, Joseph! 🎉

@stloyd stloyd deleted the bugfix/intl-depr branch December 29, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Dependencies Pull requests that update a dependency file DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stloyd @lchrusciel @Zales0123