Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for Unable to extends ShopBillingData [#11625] #11871

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Patch for Unable to extends ShopBillingData [#11625] #11871

merged 1 commit into from
Oct 29, 2020

Conversation

jbcr
Copy link
Contributor

@jbcr jbcr commented Sep 23, 2020

Q A
Branch? 1.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #11625
License MIT

Fix the relation between Channel and ShopBillingData to allow override the ShopBillingData entity.

@jbcr
Use ShopBillingDataInterface instead of ShopBillingData
7f68b62 
Fix the relation between Channel and ShopBillingData to allow override the ShopBillingData entity.
@jbcr jbcr requested a review from a team as a code owner September 23, 2020 09:02
@Zales0123 Zales0123 added the Bug Confirmed bugs or bugfixes. label Oct 15, 2020
@jbcr jbcr changed the title Patch for #11625 Patch for Unable to extends ShopBillingData [#11625] Oct 21, 2020
@lchrusciel lchrusciel merged commit 72d9178 into Sylius:1.7 Oct 29, 2020
@lchrusciel
Copy link
Member

Thanks, @jbcr! 🥇

@lchrusciel
Copy link
Member

Sorry, that it took so long, but it will be part of the next patch release ;)

@jbcr jbcr deleted the patch-2 branch November 2, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbcr @lchrusciel @Zales0123