-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Add parameter to be able to disable prepending doctrine migrations #12060
Merged
GSadee
merged 4 commits into
Sylius:1.8
from
GSadee:disable-prepending-doctrine-migrations
Dec 4, 2020
Merged
[PoC] Add parameter to be able to disable prepending doctrine migrations #12060
GSadee
merged 4 commits into
Sylius:1.8
from
GSadee:disable-prepending-doctrine-migrations
Dec 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
added
RFC
Discussions about potential changes or new features.
DX
Issues and PRs aimed at improving Developer eXperience.
Maintenance
CI configurations, READMEs, releases, etc.
labels
Nov 19, 2020
lchrusciel
reviewed
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go in this direction. But some PHPUnit tests would be nice to have. What has come up from your tries?
Tomanhez
approved these changes
Nov 19, 2020
Fixes #11851 |
arti0090
approved these changes
Nov 20, 2020
GSadee
commented
Dec 3, 2020
src/Sylius/Bundle/CoreBundle/Tests/DependencyInjection/SyliusCoreExtensionTest.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Tests/DependencyInjection/SyliusCoreExtensionTest.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
disable-prepending-doctrine-migrations
branch
5 times, most recently
from
December 3, 2020 13:41
ee0d98a
to
0813b11
Compare
lchrusciel
approved these changes
Dec 3, 2020
src/Sylius/Bundle/AdminApiBundle/Tests/DependencyInjection/SyliusAdminApiExtensionTest.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminApiBundle/Tests/DependencyInjection/SyliusAdminApiExtensionTest.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
disable-prepending-doctrine-migrations
branch
2 times, most recently
from
December 3, 2020 20:15
2e2ab0e
to
c84a4e0
Compare
probot-autolabeler
bot
added
the
Documentation
Documentation related issues and PRs - requests, fixes, proposals.
label
Dec 3, 2020
Tomanhez
force-pushed
the
disable-prepending-doctrine-migrations
branch
from
December 3, 2020 20:19
c84a4e0
to
cdeb5fc
Compare
GSadee
commented
Dec 4, 2020
src/Sylius/Bundle/AdminApiBundle/Tests/DependencyInjection/SyliusAdminApiExtensionTest.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Tests/DependencyInjection/SyliusCoreExtensionTest.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Tests/DependencyInjection/SyliusCoreExtensionTest.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Tests/DependencyInjection/SyliusCoreExtensionTest.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
disable-prepending-doctrine-migrations
branch
2 times, most recently
from
December 4, 2020 07:58
dd30df6
to
dd14347
Compare
…ion/Configuration.php
Tomanhez
force-pushed
the
disable-prepending-doctrine-migrations
branch
from
December 4, 2020 09:24
dd14347
to
c94536f
Compare
Zales0123
added a commit
that referenced
this pull request
Dec 7, 2020
…e in CoreBundle and AdminApiBundle composers (GSadee) This PR was merged into the 1.8 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | after #12060 | License | MIT Commits ------- 8d25a44 [Maintenance] Move dependency from require-dev to require in CoreBundle and AdminApiBundle composers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Documentation
Documentation related issues and PRs - requests, fixes, proposals.
DX
Issues and PRs aimed at improving Developer eXperience.
Maintenance
CI configurations, READMEs, releases, etc.
RFC
Discussions about potential changes or new features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
SyliusCoreExtension
SyliusAdminApiExtension