Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Add parameter to be able to disable prepending doctrine migrations #12060

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Nov 19, 2020

Q A
Branch? 1.8
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

TODO:

  • PHPUnit tests for SyliusCoreExtension
  • PHPUnit tests for SyliusAdminApiExtension

@GSadee GSadee added RFC Discussions about potential changes or new features. DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc. labels Nov 19, 2020
@GSadee GSadee requested a review from a team as a code owner November 19, 2020 10:41
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go in this direction. But some PHPUnit tests would be nice to have. What has come up from your tries?

@lchrusciel
Copy link
Member

Fixes #11851

@Tomanhez Tomanhez force-pushed the disable-prepending-doctrine-migrations branch 5 times, most recently from ee0d98a to 0813b11 Compare December 3, 2020 13:41
@Tomanhez Tomanhez force-pushed the disable-prepending-doctrine-migrations branch 2 times, most recently from 2e2ab0e to c84a4e0 Compare December 3, 2020 20:15
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Dec 3, 2020
@Tomanhez Tomanhez force-pushed the disable-prepending-doctrine-migrations branch from c84a4e0 to cdeb5fc Compare December 3, 2020 20:19
@Tomanhez Tomanhez force-pushed the disable-prepending-doctrine-migrations branch 2 times, most recently from dd30df6 to dd14347 Compare December 4, 2020 07:58
@Tomanhez Tomanhez force-pushed the disable-prepending-doctrine-migrations branch from dd14347 to c94536f Compare December 4, 2020 09:24
@GSadee GSadee merged commit 469883a into Sylius:1.8 Dec 4, 2020
@GSadee GSadee deleted the disable-prepending-doctrine-migrations branch December 4, 2020 09:56
Zales0123 added a commit that referenced this pull request Dec 7, 2020
…e in CoreBundle and AdminApiBundle composers (GSadee)

This PR was merged into the 1.8 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.8
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | after #12060 
| License         | MIT


Commits
-------

8d25a44 [Maintenance] Move dependency from require-dev to require in CoreBundle and AdminApiBundle composers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc. RFC Discussions about potential changes or new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants