Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Add retry to github action #12125

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Dec 4, 2020

Q A
Branch? 1.8
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

As the main solution for randomly failing jobs is to rerun them, my proposal is to rerun them by default 3 times(this number was randomly chosen by me). If the build would fail for a not random reason, it will make our builds slower, but from my observation, it is a much rarer case.

@lchrusciel lchrusciel requested a review from a team as a code owner December 4, 2020 09:39
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Dec 4, 2020
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be open to 1.8 branch I guess

@lchrusciel lchrusciel changed the base branch from master to 1.8 December 4, 2020 10:02
@GSadee GSadee merged commit dedb27e into Sylius:1.8 Dec 4, 2020
@GSadee
Copy link
Member

GSadee commented Dec 4, 2020

Thank you, Łukasz! 🥇

@lchrusciel lchrusciel deleted the check-github-rerun branch December 4, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants