Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Api][OrderItem][OrderItemUnit] Refactor api serialization groups #12206

Merged
merged 1 commit into from Jan 7, 2021
Merged

[Api][OrderItem][OrderItemUnit] Refactor api serialization groups #12206

merged 1 commit into from Jan 7, 2021

Conversation

Tomanhez
Copy link
Contributor

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
License MIT
  • OrderItem
  • OrderItemUnit

@Tomanhez Tomanhez added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). BC Break PRs introducing BC breaks (do not even try to merge). API APIs related issues and PRs. labels Dec 30, 2020
@Tomanhez Tomanhez requested a review from a team as a code owner December 30, 2020 10:06
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Dec 30, 2020
@Tomanhez Tomanhez force-pushed the refactor-api-serialization-groups-items-and-units branch 2 times, most recently from 457b39f to abcf642 Compare December 31, 2020 10:12
@Tomanhez Tomanhez force-pushed the refactor-api-serialization-groups-items-and-units branch from abcf642 to 5948089 Compare January 7, 2021 13:42
@lchrusciel lchrusciel merged commit d3015cf into Sylius:master Jan 7, 2021
@lchrusciel
Copy link
Member

Thank you, Tomasz! 🎉

Tomanhez pushed a commit to Tomanhez/Sylius that referenced this pull request Jan 7, 2021
@lchrusciel @Tomanhez
refactor Sylius#12206 [Api][OrderItem][OrderItemUnit] Refactor api se…
1817a3a 
…rialization groups (Tomanhez)

This PR was merged into the 1.9-dev branch.
labels: bc-break

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | yes
| Deprecations?   | no
| License         | MIT

- [x]  OrderItem
- [x] OrderItemUnit

Commits
-------

5948089 Refactor Item and Unit serialization groups
lchrusciel added a commit that referenced this pull request Jan 7, 2021
@lchrusciel
refactor #12212 [Api][Promotion][Province] Refactor api serialization…
f66402f 
… groups (lchrusciel)

This PR was merged into the 1.9-dev branch.
labels: bc-break

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| License         | MIT

- [x] Promotion
- [x] Province

<!--
 - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

1817a3a refactor #12206 [Api][OrderItem][OrderItemUnit] Refactor api serialization groups (Tomanhez)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

Assignees
No one assigned
Labels
API APIs related issues and PRs. BC Break PRs introducing BC breaks (do not even try to merge). Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tomanhez @lchrusciel