Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Api][OrderItem][OrderItemUnit] Refactor api serialization groups #12206

Merged
merged 1 commit into from
Jan 7, 2021
Merged

[Api][OrderItem][OrderItemUnit] Refactor api serialization groups #12206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UPGRADE-1.8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ If you are using they on your custom entity `api_resource` configuration or seri
`order:create` changed to: `shop:order:create`
`order:read` changed to: `admin:order:read`
`order:update` changed to: `admin:order:update`
`order_item:read` changed to: `admin:order_item:read` and `shop:order_item:read`
`order_item_unit:read` changed to: `admin:order_item_unit:read` and `shop:order_item_unit:read`
Tomanhez marked this conversation as resolved.
Show resolved Hide resolved
`product:create` changed to: `admin:product:create`
`product:read` changed to: `admin:product:read` and `shop:product:read`
`product:update` changed to: `admin:product:update`
Expand Down
12 changes: 6 additions & 6 deletions src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/OrderItem.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,23 @@
xsi:schemaLocation="https://api-platform.com/schema/metadata https://api-platform.com/schema/metadata/metadata-2.0.xsd"
>
<resource class="%sylius.model.order_item.class%" shortName="OrderItem">
<attribute name="normalization_context">
<attribute name="groups">
<attribute>order_item:read</attribute>
</attribute>
</attribute>

<collectionOperations />

<itemOperations>
<itemOperation name="admin_get">
<attribute name="method">GET</attribute>
<attribute name="path">/admin/order-items/{id}</attribute>
<attribute name="normalization_context">
<attribute name="groups">admin:order_item:read</attribute>
</attribute>
</itemOperation>

<itemOperation name="shop_get">
<attribute name="method">GET</attribute>
<attribute name="path">/shop/order-items/{id}</attribute>
<attribute name="normalization_context">
<attribute name="groups">shop:order_item:read</attribute>
</attribute>
</itemOperation>
</itemOperations>

Expand Down
14 changes: 7 additions & 7 deletions src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/OrderItemUnit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,26 @@
xsi:schemaLocation="https://api-platform.com/schema/metadata https://api-platform.com/schema/metadata/metadata-2.0.xsd"
>
<resource class="%sylius.model.order_item_unit.class%" shortName="OrderItemUnit">
<attribute name="normalization_context">
<attribute name="groups">
<attribute>order_item_unit:read</attribute>
</attribute>
</attribute>
<collectionOperations />

<itemOperations>
<itemOperation name="admin_get">
<attribute name="method">GET</attribute>
<attribute name="path">/admin/order-item-units/{id}</attribute>
<attribute name="normalization_context">
<attribute name="groups">admin:order_item_unit:read</attribute>
</attribute>
</itemOperation>

<itemOperation name="shop_get">
<attribute name="method">GET</attribute>
<attribute name="path">/shop/order-item-units/{id}</attribute>
<attribute name="normalization_context">
<attribute name="groups">shop:order_item_unit:read</attribute>
</attribute>
</itemOperation>
</itemOperations>

<collectionOperations />

<property name="id" identifier="true" writable="false" />
<property name="shippable" />
</resource>
Expand Down
55 changes: 35 additions & 20 deletions src/Sylius/Bundle/ApiBundle/Resources/config/serialization/OrderItem.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,64 +17,79 @@
>
<class name="Sylius\Component\Core\Model\OrderItem">
<attribute name="id">
<group>shop:order:account:read</group>
<group>order_item:read</group>
<group>admin:order:read</group>
<group>admin:order_item:read</group>
<group>shop:cart:read</group>
<group>shop:order:account:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="code">
<group>order_item:read</group>
<group>admin:order:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="order">
<group>order_item:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="variant">
<group>shop:order:account:read</group>
<group>order_item:read</group>
<group>admin:order:read</group>
<group>admin:order_item:read</group>
<group>shop:cart:read</group>
<group>shop:order:account:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="quantity">
<group>shop:order:account:read</group>
<group>order_item:read</group>
<group>admin:order:read</group>
<group>admin:order_item:read</group>
<group>shop:cart:read</group>
<group>shop:order:account:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="unitPrice">
<group>order_item:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="units">
<group>order_item:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="adjustments">
<group>order_item:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="adjustmentsRecursively">
<group>order_item:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="adjustmentsTotal">
<group>order_item:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="adjustmentsTotalRecursively">
<group>order_item:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="product">
<group>order_item:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="productName">
<group>shop:order:account:read</group>
<group>order_item:read</group>
<group>shop:cart:read</group>
<group>admin:order:read</group>
<group>admin:order_item:read</group>
<group>shop:cart:read</group>
<group>shop:order:account:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="subtotal">
<group>order_item:read</group>
<group>admin:order:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
<attribute name="total">
<group>order_item:read</group>
<group>admin:order:read</group>
<group>admin:order_item:read</group>
<group>shop:order_item:read</group>
</attribute>
</class>
</serializer>
6 changes: 4 additions & 2 deletions src/Sylius/Bundle/ApiBundle/Resources/config/serialization/OrderItemUnit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@
>
<class name="Sylius\Component\Core\Model\OrderItemUnit">
<attribute name="id">
<group>order_item_unit:read</group>
<group>admin:order_item_unit:read</group>
<group>shop:order_item_unit:read</group>
</attribute>
<attribute name="shippable">
<group>order_item_unit:read</group>
<group>admin:order_item_unit:read</group>
<group>shop:order_item_unit:read</group>
</attribute>
</class>
</serializer>