Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] improve tests for overwriting api configs #12411

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[API] improve tests for overwriting api configs #12411

merged 1 commit into from
Mar 4, 2021

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Mar 3, 2021

Q A
Branch? 1.9
Bug fix? no
New feature? no
BC breaks? no
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner March 3, 2021 13:10
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Mar 3, 2021
GSadee
GSadee approved these changes Mar 4, 2021
View reviewed changes
src/Sylius/Bundle/ApiBundle/test/src/Tests/PromotionTest.php
}

/**
* @test
*/
public function it_allows_to_get_collection_as_an_login_administrator_on_resource_from_api_bundle_with_customized_path(): void
public function it_gets_resource_collection_as_a_admin_by_custom_path(): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function it_gets_resource_collection_as_a_admin_by_custom_path(): void
public function it_gets_resource_collection_as_an_logged_in_administrator_by_custom_path(): void

@GSadee GSadee merged commit 452fa79 into Sylius:1.9 Mar 4, 2021
@GSadee
Copy link
Member

GSadee commented Mar 4, 2021

Thank you, Adam! 🎉

@GSadee GSadee mentioned this pull request Mar 4, 2021
Closed
@AdamKasp AdamKasp deleted the imrovements-to-tests-api-overwriting-configs branch July 19, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamKasp @GSadee @arti0090