[BUG] Product options null value returns 400 instead of 500 #12501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirDomin
commented
Apr 1, 2021
SirDomin
commented
| Q | A |
|---|---|
| Branch? | 1.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
SirDomin
changed the title
arti0090
approved these changes
Apr 1, 2021
GSadee
reviewed
Apr 1, 2021
SirDomin
force-pushed
the
product-options-null-value
branch
from
201c765
to
78c165d
Compare
GSadee
reviewed
Apr 1, 2021
| @@ -45,7 +45,7 @@ public function addOptionValue(ProductOptionValueInterface $optionValue): void; | |||
|
|
|||
| public function removeOptionValue(ProductOptionValueInterface $optionValue): void; | |||
|
|
|||
| public function hasOptionValue(ProductOptionValueInterface $optionValue): bool; | |||
| public function hasOptionValue(?ProductOptionValueInterface $optionValue): bool; | |||
There was a problem hiding this comment.
I wonder if this change is not a BC Break, although it expands the accepted argument, wdyt @lchrusciel
There was a problem hiding this comment.
🚨 That's a BC break, all classes implementing this interface have to change their method signature.
SirDomin
force-pushed
the
product-options-null-value
branch
from
78c165d
to
2eedf53
Compare
SirDomin
force-pushed
the
product-options-null-value
branch
from
2eedf53
to
e11571e
Compare
lchrusciel
approved these changes
Apr 1, 2021
| { | ||
| return $this->optionValues->contains($optionValue); | ||
| return $optionValue === null ? true : $this->optionValues->contains($optionValue); |
There was a problem hiding this comment.
this is abit tricky, because by returning true we force it ProductVariant to dont allow null as argument and handle it as bad request.
There was a problem hiding this comment.
It is tricky because it feels wrong to check whether a product variant has an option value null. I think we should fix it upstream and do not let null to be passed to this method in the first place.
|
Thank you, @SirDomin! 🥇 |
pamil
added a commit
that referenced
this pull request
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.