Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre/post complete events are not triggered #12541

Closed
LucaGallinari opened this issue Apr 19, 2021 · 1 comment
Closed

Pre/post complete events are not triggered #12541

LucaGallinari opened this issue Apr 19, 2021 · 1 comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Comments

@LucaGallinari
Copy link
Contributor

Sylius docs version: 1.8 / latest

Description
As stated in multiple issues (#8109, #8395) pre and post complete events are not triggered upon completing a payment. They are triggered only when you confirm the payment from the admin.
For this reason I think that the Payment page in the docs should alert about this or don't even mention that these event are called, as their use is inconsistent among the application. It must be preferred to listen the "pay" callback on the "sylius_order_payment" object, like this:

winzou_state_machine:
    sylius_order_payment:
        callbacks:
            after:
                my_custom_logic_name:
                    on: ["pay"]
                    do: ["@YOUR_SERVICE_ID", "THE_METHOD_TO_CALL"]
                    args: ["object"]

What do you think?

@sebheitzmann
Copy link

The documentation is not clear about that. I Agree that the event should be triggered after a gateway payment validation

@NoResponseMate NoResponseMate added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Jun 16, 2023
@GSadee GSadee closed this as completed in 875171e Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

No branches or pull requests

3 participants