Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre/post payment events not being triggered #8395

Closed
kochen opened this issue Aug 11, 2017 · 14 comments · Fixed by #8630
Closed

pre/post payment events not being triggered #8395

kochen opened this issue Aug 11, 2017 · 14 comments · Fixed by #8630
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. Stale Issues and PRs with no recent activity, about to be closed soon.

Comments

@kochen
Copy link
Contributor

kochen commented Aug 11, 2017

Following this example: http://docs.sylius.org/en/latest/cookbook/disabling-order-confirmation-email.html#overriding-service-definition

I've noticed that:

  1. the event name should actually be: sylius.payment.post_complete
  2. overriding the service definition does cancel the original orderConfirmation email but does not send one after payment, because non of the pre/post payment complete events are triggered.

PR for the documentation will follow after the main bug is fixed.

@kochen
Copy link
Contributor Author

kochen commented Aug 11, 2017

related to: #8109

@pjedrzejewski pjedrzejewski added this to the v1.0.0 milestone Aug 16, 2017
@pjedrzejewski pjedrzejewski modified the milestones: v1.1.0, v1.0.0 Aug 31, 2017
@pjedrzejewski pjedrzejewski added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Sep 12, 2017
@kochen
Copy link
Contributor Author

kochen commented Sep 12, 2017

@pjedzejewski shouldn't this be fixed (later release?), instead of jut changing the docs because it doesn't work?

@pjedrzejewski pjedrzejewski reopened this Sep 12, 2017
@pjedrzejewski
Copy link
Member

@kochen Sorry it was automatically closed via reference. We removed docs to avoid confusion but we need to figure out a better way to solve it.

@kochen
Copy link
Contributor Author

kochen commented Sep 12, 2017

@pjedzejewski I know.
I say move it to v1.1.0, it's not a must have for v1.0.0

@stale
Copy link

stale bot commented Dec 11, 2017

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Dec 11, 2017
@kochen
Copy link
Contributor Author

kochen commented Dec 13, 2017

@pjedzejewski any plan to pick this up?

@stale stale bot removed the Stale Issues and PRs with no recent activity, about to be closed soon. label Dec 13, 2017
@stale
Copy link

stale bot commented Mar 13, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Mar 13, 2018
@czende
Copy link
Contributor

czende commented Mar 19, 2018

@kochen Is this solved or not? I have same problem as described here #8109 :/

@stale stale bot removed the Stale Issues and PRs with no recent activity, about to be closed soon. label Mar 19, 2018
@kochen
Copy link
Contributor Author

kochen commented Mar 28, 2018

@czende As far as I know it was never address directly.
But might have been addressed indirectly - never checked...

@pamil
Copy link
Contributor

pamil commented Apr 6, 2018

IIRC there was no work done with this one.

@pamil pamil removed this from the 1.1 milestone Apr 27, 2018
@stale
Copy link

stale bot commented Jul 26, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Jul 26, 2018
@stale stale bot closed this as completed Aug 2, 2018
@tsogoo
Copy link

tsogoo commented Sep 12, 2019

I think sylius.payment.post_complete event is still not triggered

@Gounlaf
Copy link

Gounlaf commented Mar 7, 2020

I think sylius.payment.post_complete event is still not triggered

I didn't found any trigger of this event too =/
The official InvoicingPlugin doesn't rely on it too.

@LucaGallinari
Copy link
Contributor

The sylius.payment.* events are still not triggered. They are triggered only when the payment is manually confirmed from the admin.
A possible workaround is to use the "pay" callback on the "sylius_order_payment" entity. So you have to do something like this in your _sylius.yaml:

winzou_state_machine:
    sylius_order_payment:
        callbacks:
            after:
                my_custom_logic_name:
                    on: ["pay"]
                    do: ["@YOUR_SERVICE_ID", "THE_METHOD_TO_CALL"]
                    args: ["object"]

I opened another issue #12541, at least the docs should be modified accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. Stale Issues and PRs with no recent activity, about to be closed soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants