Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Use explicit bus instead of the default one #12546

Merged
merged 1 commit into from
Apr 20, 2021
Merged

[Minor] Use explicit bus instead of the default one #12546

merged 1 commit into from
Apr 20, 2021

Conversation

lchrusciel
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@lchrusciel lchrusciel added the Bug Confirmed bugs or bugfixes. label Apr 19, 2021
@lchrusciel lchrusciel requested a review from a team as a code owner April 19, 2021 14:08
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Apr 19, 2021
pamil
pamil approved these changes Apr 20, 2021
View reviewed changes
src/Sylius/Bundle/ApiBundle/Resources/config/services/event_handlers.xml
@@ -17,7 +17,7 @@
>
<services>
<service id="Sylius\Bundle\ApiBundle\EventHandler\OrderCompletedHandler">
<argument type="service" id="messenger.default_bus" />
<argument type="service" id="sylius_default.bus" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change - just a note that we probably should work on the naming of these buses. It doesn't follow convention (sylius_default.bus instead of sylius.default_bus or sylius.bus.default) and it's also a default bus for API Bundle (and it's defined there).

@pamil pamil merged commit 695a8b1 into Sylius:1.9 Apr 20, 2021
@pamil
Copy link
Contributor

pamil commented Apr 20, 2021

Thank you, Łukasz! 🥇

@pamil pamil mentioned this pull request Apr 20, 2021
Closed
@lchrusciel lchrusciel deleted the explicit-bus branch April 20, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lchrusciel @pamil