Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Use explicit bus instead of the default one #12546

Merged
merged 1 commit into from
Apr 20, 2021
Merged

[Minor] Use explicit bus instead of the default one #12546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Sylius/Bundle/ApiBundle/Resources/config/services/event_handlers.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
>
<services>
<service id="Sylius\Bundle\ApiBundle\EventHandler\OrderCompletedHandler">
<argument type="service" id="messenger.default_bus" />
<argument type="service" id="sylius_default.bus" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change - just a note that we probably should work on the naming of these buses. It doesn't follow convention (sylius_default.bus instead of sylius.default_bus or sylius.bus.default) and it's also a default bus for API Bundle (and it's defined there).

<argument type="service" id="sylius.repository.order" />
<tag name="messenger.message_handler" bus="sylius_event.bus"/>
</service>
Expand Down