Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document required Node.js version #12641

Closed
bram-pkg opened this issue May 17, 2021 · 5 comments
Closed

Document required Node.js version #12641

bram-pkg opened this issue May 17, 2021 · 5 comments
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.

Comments

@bram-pkg
Copy link

Currently it doesn't say anywhere which Node.js version is required.

yarn install or npm install both don't work on Node.js 16.
@victor-v-bv
Copy link

It's only tested with NodeJS 10.

@JoppeDC
Copy link

JoppeDC commented Jun 13, 2022

Bump, maybe add an nvmrc file, or at least mention the version in the docs?

@NoResponseMate NoResponseMate added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jul 26, 2022
@NoResponseMate
Copy link
Contributor

Hi @bram-pkg
The version of node changes quite a lot.
At the moment the best way would be to update the requirement docs.
Would you be able to do it?

@arti0090 arti0090 mentioned this issue Aug 21, 2022
Merged
@arti0090
Copy link
Contributor

@NoResponseMate I think it might help it 😉

GSadee added a commit that referenced this issue Oct 10, 2022
@GSadee
minor #14246 [DOCS] Add note about min node version (arti0090)
17c56dc 
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11              |
| License         | MIT                                                          |

It should help this issue #12641


Commits
-------

1cfa0bb [DOCS] Add note about min node version
fc9f7fd change the version
@NoResponseMate
Copy link
Contributor

Hi @bram-pkg 👋

As this has been fixed and the supported versions of node have been added to the requirements doc I'm closing this.

Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@NoResponseMate @JoppeDC @bram-pkg @arti0090 @victor-v-bv