[API] Denying usage of coupon for invalid promotion #12704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Feature
Zales0123
changed the title
Zales0123
force-pushed
the
api-invalid-promotion-coupon-usage
branch
from
eb7f5d4
to
81bf5da
Compare
GSadee
approved these changes
Jun 9, 2021
| /** @var PromotionInterface $promotion */ | ||
| $promotion = $promotionCoupon->getPromotion(); | ||
|
|
||
| if (!$promotion->getChannels()->contains($cart->getChannel())) { |
There was a problem hiding this comment.
Suggested change
| if (!$promotion->getChannels()->contains($cart->getChannel())) { | |
| if (!$promotion->hasChannel($cart->getChannel())) { |
|
Thank you, Mateusz! 馃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also unified the validation message to always show that coupon code is invalid (from the perspective of a Customer, much more natural information than
Promotion is invalid馃拑)