[Api] Denying usage of unexisting promotion coupon #12703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomanhez
changed the title
Tomanhez
force-pushed
the
denying-usage-of-unexisting-promotion-coupon
branch
2 times, most recently
from
248258b
to
55dd8dd
Compare
Zales0123
reviewed
Jun 9, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/PromotionCouponEligibilityValidator.php
Outdated
Show resolved
Hide resolved
...lius/Bundle/ApiBundle/spec/Validator/Constraints/PromotionCouponEligibilityValidatorSpec.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
denying-usage-of-unexisting-promotion-coupon
branch
2 times, most recently
from
0364306
to
a00a8c8
Compare
Zales0123
approved these changes
Jun 9, 2021
src/Sylius/Bundle/PromotionBundle/Resources/translations/validators.en.yml
Outdated
Show resolved
Hide resolved
Zales0123
requested changes
Jun 9, 2021
src/Sylius/Bundle/ApiBundle/Validator/Constraints/PromotionCouponEligibilityValidator.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
denying-usage-of-unexisting-promotion-coupon
branch
from
a00a8c8
to
0e73cad
Compare
Zales0123
approved these changes
Jun 9, 2021
|
Thanks, Tomasz! 🎉 |
Zales0123
added a commit
to Zales0123/Sylius
that referenced
this pull request
Jun 9, 2021
GSadee
added a commit
that referenced
this pull request
Jun 9, 2021
…ales0123) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT I've also unified the validation message to always show that coupon code is invalid (from the perspective of a Customer, much more natural information than `Promotion is invalid` 💃) Commits ------- 4fbbb31 [API] Import proper context to fix coupon invalidity checking de57cf1 Validate coupon on promotion from another channel 4f2a5d9 Receiving no discount for not-in-time coupon promotion 274554c Receiving no discount for already used coupon promotion 4fbf939 Receiving no discount if coupon promotion rules are not fulfilled bcc3354 Validator refactoring 70b2666 Unify invalid coupon/promotion validation message 831ab89 PromotionCouponEligbilityValidator refactoring 81bf5da Incorporate changes from #12703 into the checker
Tomanhez
pushed a commit
to Tomanhez/Sylius
that referenced
this pull request
Jun 24, 2021
Tomanhez
pushed a commit
to Tomanhez/Sylius
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| License | MIT