Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] Add change of tax by address #12718

Merged
merged 5 commits into from Jun 23, 2021
Merged

[POC] Add change of tax by address #12718

merged 5 commits into from Jun 23, 2021

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented Jun 18, 2021 •
edited by CoderMaggie

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? not sure
Related tickets related to #10946
License MIT

Zrzut ekranu 2021-06-18 o 08 33 40
Zrzut ekranu 2021-06-18 o 08 33 50

@arti0090 arti0090 requested a review from a team as a code owner June 18, 2021 06:35
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jun 18, 2021
@arti0090
Copy link
Contributor Author

arti0090 commented Jun 18, 2021 •
edited

If this PR will be confirmed positively I think there would be needed and note in upgrade file about constructor, and maybe this PR should have branch changed to 1.10 .

arti0090
arti0090 commented Jun 18, 2021
View reviewed changes
config/services.yaml Outdated Show resolved Hide resolved
@vvasiloi
Copy link
Contributor

@arti0090 is this meant to solve #10946?

@arti0090
Copy link
Contributor Author

Hi @vvasiloi and alter ego @victor-v-bv 😄 Well this is one way of how to fix this, the second is here #12724 but I am looking to discuss / find which way to go.

@arti0090 arti0090 mentioned this pull request Jun 18, 2021
Closed
@arti0090 arti0090 force-pushed the cookbook-taxes branch 2 times, most recently from 64c6319 to 0f6e38a Compare June 18, 2021 12:00
@arti0090 arti0090 force-pushed the cookbook-taxes branch 2 times, most recently from 51b03a1 to d064dc9 Compare June 22, 2021 07:40
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jun 22, 2021
@GSadee GSadee merged commit 4d1d948 into Sylius:master Jun 23, 2021
@GSadee
Copy link
Member

GSadee commented Jun 23, 2021

Thank you, @arti0090! 🎉

@vvasiloi vvasiloi mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie left review comments

@AdamKasp AdamKasp AdamKasp left review comments

@GSadee GSadee GSadee approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@arti0090 @vvasiloi @GSadee @lchrusciel @CoderMaggie @AdamKasp