[DOCS]Add cookbook with how to customize taxes #12724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 1.9-dev branch. Discussion ---------- Part of Sylius#12298. <hr /> **TODO:** - [x] Better userland deprecations handling in phpspec Commits ------- afafde4 Allow for PHP 8.0 to be installed by Composer 33d549a Run tests with PHP 8.0 on GitHub Actions 552d3df Fix PHP 8.0 deprecations - required parameter follows optional parameter 47dae27 Ignore userland deprecations during phpspec execution a3b2fb0 Specify versions as strings not numerals in GitHub Actions configs 39634bf Fix the incompatible typehint for TestKernel::configureRoutes in CoreBundle 4d07347 Make ApiBundle installable with PHP 8
* 1.9: [Order] Add recalculating adjustments total after removing adjustments [OrderItem] Add versioning the order item entity
… GSadee, SirDomin) This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | License | MIT <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 410863b [API][Products] Add custom Taxon filter 6816d57 [Api][Products][Taxons] implement basic filtering by taxon ad98b6c [API][Product] filtering by taxon in channel 889f37d [API] Change the argument in TaxonFilter service definition 886d9d2 [API][Product] fixes to taxon filter f4f0d83 remove comment
Updates the requirements on [vimeo/psalm](https://github.com/vimeo/psalm) to permit the latest version. - [Release notes](https://github.com/vimeo/psalm/releases) - [Commits](vimeo/psalm@4.7.0...4.7.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 9d91e25 refactor + set channel on request f5b3c76 remove currency step 9caa1c2 behat hostname fix
This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | | Related tickets | | License | MIT <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 090d1dd remove productCode, mention in upgrade file 1df4714 update command 9a07588 pr-fix
…ArgumentToIdentifierMap
…hez, arti0090) This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | License | MIT Commits ------- 3e2cf94 Remove /AddProductReviewCommandFieldItemIriToIdentifierDenormalizer 70dff14 Add ItemIriToIdentifierConverter e037a75 dd CommandFieldItemIriToIdentifierDenormalizerSpec and CommandItemIriArgumentToIdentifierMap 6bb6936 Add fixes for tests and implementation deb2cfa replace code to iri in ChangePaymentMethod and change id to code in PaymentMethod 05a355b Add ADR and note to Upgrade file f7b6f2d Add fixes for tests and implementations 8392bcd Implement another endpoints 08cc365 Rebase and rework product adding endpoint 786a7d6 Fix issues in configuration and failing behat
…-26-06-03 [AUTO] Updated translations from Crowdin (master)
* 1.9: [Documentation] Move Refund Process Cookbook to Payments section [Documentation] Fix Refund Process Cookbook
* 1.10: [Documentation] Move Refund Process Cookbook to Payments section [Documentation] Fix Refund Process Cookbook
…ion (Zales0123) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT I've also unified the validation message to always show that coupon code is invalid (from the perspective of a Customer, much more natural information than `Promotion is invalid` 💃) Commits ------- 4fbbb31 [API] Import proper context to fix coupon invalidity checking de57cf1 Validate coupon on promotion from another channel 4f2a5d9 Receiving no discount for not-in-time coupon promotion 274554c Receiving no discount for already used coupon promotion 4fbf939 Receiving no discount if coupon promotion rules are not fulfilled bcc3354 Validator refactoring 70b2666 Unify invalid coupon/promotion validation message 831ab89 PromotionCouponEligbilityValidator refactoring 81bf5da Incorporate changes from Sylius#12703 into the checker
* 1.9: [Documentation] Typo fixes on the refunds process cookbook Tweaks on the refunds process cookbook
* 1.10: [Documentation] Typo fixes on the refunds process cookbook Tweaks on the refunds process cookbook
* 1.9: [Documentation] Fix links in the refunds process cookbook
* 1.10: [Documentation] Fix links in the refunds process cookbook
* 1.9: Fix the build with Symfony 5.3
* 1.10: Fix the build with Symfony 5.3
… Actions (pamil) This PR was merged into the 1.10 branch. Discussion ---------- Commits ------- 14bd63d Fix the build after upgrade to Symfony 5.3 in GitHub Actions
* 1.10: Fix the build after upgrade to Symfony 5.3 in GitHub Actions
* 1.10: Update templates directory in Themes doc
* 1.9: Fix typo and improve error message
* 1.10: Fix typo and improve error message
* 1.9: Remove non-exist attribute Fix Country api resource properties
* 1.10: Remove non-exist attribute Fix Country api resource properties
arti0090
added
the
Documentation
GSadee
reviewed
Jun 18, 2021
| `OrderTaxesProcessor.php` from `Sylius/Component/Core/OrderProcessing/`. First let's copy code from original Processor to our service | ||
| in ``src/OrderProcessing/OrderTaxesProcessor.php`` | ||
|
|
||
| .. code-block:: php |
There was a problem hiding this comment.
I wonder if it wouldn't be better not to show the entire copied service because some things can change in future 🤔
arti0090
force-pushed
the
cookbook-taxes-v2
branch
from
6081e7e
to
902eb60
Compare
|
Closing in fawor of #12731 |
GSadee
added a commit
that referenced
this pull request
Jun 22, 2021
This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | same as #12724 but on 1.9 branch | License | MIT Opened new PR as old one was making a lot of merge conflicts. Commits ------- 934749e Add cookbook with how to change tax address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10946
And to 2nd solution from #12718