PHP 7.4 syntax in bundles vol.2 #13039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Enhancement
Arminek
approved these changes
Sep 2, 2021
Zales0123
force-pushed
the
php7.4-syntax-bundles-core
branch
from
a049b55
to
6b87787
Compare
probot-autolabeler
bot
added
Documentation
Zales0123
force-pushed
the
php7.4-syntax-bundles-core
branch
from
6b87787
to
54106f7
Compare
GSadee
approved these changes
Sep 17, 2021
| @@ -30,7 +30,7 @@ final class ShowAvailablePluginsCommand extends Command | |||
| * @phpstan-var ArrayCollection<PluginInfo> | |||
| * @psalm-var ArrayCollection<array-key, PluginInfo> | |||
| */ | |||
| private $plugins; | |||
| private ArrayCollection $plugins; | |||
There was a problem hiding this comment.
Suggested change
| private ArrayCollection $plugins; | |
| private Collection $plugins; |
?
Comment on lines
+16
to
+17
| use Faker\Generator; | ||
| use Faker\Factory; |
There was a problem hiding this comment.
Should be moved lower to other "uses"
|
Thanks, Mateusz! 馃帀 |
GSadee
added a commit
that referenced
this pull request
Sep 17, 2021
This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | based on #13039, related to #12891 | License | MIT Last, but not least 馃悗 Commits ------- 676df96 PHP 7.4 syntax in bundles vol.3 e493824 Fix use imports and some bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreBundle+ PHP 7.4 = 馃帀