Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.4 syntax #12891

Closed
10 tasks done
Zales0123 opened this issue Aug 13, 2021 · 1 comment
Closed
10 tasks done

PHP 7.4 syntax #12891

Zales0123 opened this issue Aug 13, 2021 · 1 comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Comments

@Zales0123
Copy link
Member

Zales0123 commented Aug 13, 2021 •
edited

This issue is created to coordinate efforts and have one space to reference to all of the PR's aiming to use PHP7.4 syntax in Sylius

Hello, folks! 👋

I've decided to open this issue, to be transparent with our efforts to finally use PHP 7.4 syntax on all Sylius' supported repositories. Let's face the truth - it's a little bit late 💃 But, on the other hand, better late than never 🐎

I already started the work, with this PR on SyliusResourceBundle. The path I chose is to use rectorphp, as it's working spectacularly with the code syntax upgrade. There are some things needed to be done additionally (probably upgrading PHPStan or other coding-standard relate libraries), but it should not be a big problem.

Feel free to participate, if you like to 🎉 I'm also sure, that we can do better (and faster) when we decide to bump the minimal PHP version to 8.0 (active support of PHP 7.4 ends at the end of November ⚠️) 💪

To-do:

Live long and prosper, Sylius Community 🖖 🚀
@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Aug 13, 2021
vvasiloi added a commit to vvasiloi/Sylius that referenced this issue Aug 14, 2021
@vvasiloi
replace properties type annotations with built-in type hints (contrib…
91f5e3a 
…ution to Sylius#12891)
vvasiloi added a commit to vvasiloi/Sylius that referenced this issue Aug 14, 2021
@vvasiloi
replace properties type annotations with built-in type hints (Sylius#…
60aa36e 
…12891)
vvasiloi added a commit to vvasiloi/Sylius that referenced this issue Aug 14, 2021
@vvasiloi
add property type-hints (Sylius#12891)
e28930f
vvasiloi added a commit to vvasiloi/Sylius that referenced this issue Aug 14, 2021
@vvasiloi
add property type-hints (Sylius#12891)
55229b1
vvasiloi added a commit to vvasiloi/Sylius that referenced this issue Aug 23, 2021
@vvasiloi
add property type-hints (Sylius#12891)
053521e
vvasiloi added a commit to vvasiloi/Sylius that referenced this issue Aug 23, 2021
@vvasiloi
Revert "add property type-hints (Sylius#12891)"
7df037f 
This reverts commit 053521e
This was referenced Aug 26, 2021
Merged
Merged
Merged
Merged
GSadee added a commit that referenced this issue Sep 3, 2021
@GSadee
refactor #13012 Use PHP 7.4 syntax in Sylius components (Zales0123)
e4b7c8a 
This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.10
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | related to #12891
| License         | MIT

I know, it's probably unreviewable (but bundles will be worse 😄). In tests we trust 🖖 🚀 

Commits
-------

79fbdf6 Use PHP 7.4 syntax in Sylius components
b3776ba After review fixes
GSadee added a commit that referenced this issue Sep 6, 2021
@GSadee
refactor #13038 PHP 7.4 syntax in Sylius bundles vol.1 (Zales0123)
592336e 
This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.10
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | related to #12891
| License         | MIT

All bundles except `CoreBundle` and `ApiBundle` which I left for dessert (and by _dessert_ I mean separate PRs - they're just too big 🚀)

Commits
-------

de8a9c8 PHP 7.4 syntax in bundles vol.1
This was referenced Sep 6, 2021
Merged
Merged
Zales0123 added a commit to Sylius/InvoicingPlugin that referenced this issue Sep 16, 2021
@Zales0123
refactor #249 Use PHP 7.4 syntax (GSadee)
e3457ca 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Related to Sylius/Sylius#12891

Commits
-------

f0b0567 Use PHP 7.4 syntax
a667662 [Behat] Use PHP 7.4 syntax
772ec3e [LineItem] Fix return type of invoice
95e2a09 [Composer] Revert adding rector because of a problem with ecs
ca9d93e [LineItem] Revert changing return type of invoice
@Zales0123 Zales0123 mentioned this issue Sep 16, 2021
Merged
Zales0123 added a commit to Sylius/RefundPlugin that referenced this issue Sep 16, 2021
@Zales0123
refactor #330 Use PHP 7.4 syntax (GSadee)
6dbc2e0 
This PR was merged into the 1.0 branch.

Discussion
----------

Related to Sylius/Sylius#12891

Commits
-------

79fede9 Use PHP 7.4 syntax
3807172 [Behat] Use PHP 7.4 syntax
cb45c19 [Composer] Fix ecs
8fd4159 Fix return types of CreditMemo and CustomerBillingData
GSadee added a commit that referenced this issue Sep 17, 2021
@GSadee
refactor #13039 PHP 7.4 syntax in bundles vol.2 (Zales0123)
069cdfd 
This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.10
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | based on #13038, related to #12891
| License         | MIT

`CoreBundle` + PHP 7.4  = 🎉 

Commits
-------

54106f7 PHP 7.4 syntax in bundles vol.2
fb4158e Fix coding standards
GSadee added a commit that referenced this issue Sep 17, 2021
@GSadee
refactor #13040 PHP 7.4 syntax in bundles vol.3 (Zales0123)
d8626f4 
This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.10
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | based on #13039, related to #12891
| License         | MIT

Last, but not least 🐎 

Commits
-------

676df96 PHP 7.4 syntax in bundles vol.3
e493824 Fix use imports and some bugs
GSadee added a commit that referenced this issue Sep 17, 2021
@GSadee
refactor #13116 PHP 7.4 syntax in Behat (Zales0123)
5570819 
This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.10
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | based on #13040, related to #12891
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

a99d3b2 PHP 7.4 syntax in Behat
@Zales0123 Zales0123 mentioned this issue Sep 17, 2021
Merged
SirDomin added a commit to Sylius/PayPalPlugin that referenced this issue Sep 22, 2021
@SirDomin
minor #211 Bump PHP to 7.4 and use its syntax (Zales0123)
d2bc75e 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Related to Sylius/Sylius#12891

Commits
-------

3e1ca41 Bump PHP to 7.4 and use its syntax
This was referenced Oct 11, 2021
Merged
Merged
Merged
lchrusciel added a commit to Sylius/SyliusDemo that referenced this issue Oct 27, 2021
@lchrusciel
refactor #210 Use PHP7.4 syntax (Zales0123)
570f49c 
This PR was merged into the stable branch.

Discussion
----------

Related to Sylius/Sylius#12891

Commits
-------

8e0f789 Install rector
02cfbad Use PHP 7.4 syntax
lchrusciel added a commit to Sylius/SyliusThemeBundle that referenced this issue Dec 20, 2021
@lchrusciel
refactor #110 Use PHP 7.4 syntax (Zales0123)
707bcf5 
This PR was merged into the 2.2-dev branch.

Discussion
----------

Related to Sylius/Sylius#12891 🖖 🚀 

Commits
-------

cea92fc Do not use empty string as valid locale
7601b50 Use PHP 7.4 syntax
@Zales0123
Copy link
Member Author

We can consider it done 🖖

@GSadee GSadee mentioned this issue May 31, 2022
Merged
AdamKasp added a commit that referenced this issue Jun 1, 2022
@AdamKasp
refactor #14038 [Behat] Refactor to use PHP 7.4 syntax (GSadee)
6d8778f 
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11|
| Bug fix?        | no                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no|
| Related tickets | continuation of #12891 and #13268                      |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

5477cd0 [Behat] Refactor to use PHP 7.4 syntax
e3961b0 [Behat] Fix CS after introducing PHP 7.4 syntax
eb127a4 [Behat] Fix typehint of mink parameters property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Zales0123