Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotions][Api] Add test for creation rule #13068

Merged
merged 1 commit into from Sep 10, 2021
Merged

[CatalogPromotions][Api] Add test for creation rule #13068

merged 1 commit into from Sep 10, 2021

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented Sep 7, 2021

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@Tomanhez Tomanhez requested a review from a team as a code owner September 7, 2021 11:54
@Tomanhez Tomanhez force-pushed the cp-rule-ui-validation branch 2 times, most recently from 9149144 to 5fa4158 Compare September 7, 2021 17:20
@Tomanhez Tomanhez changed the title [CatalogPromotions][Api] Add test for creation rule [WIP][CatalogPromotions][Api] Add test for creation rule Sep 7, 2021
@Tomanhez Tomanhez force-pushed the cp-rule-ui-validation branch 11 times, most recently from 4d823f7 to 602dde3 Compare September 8, 2021 16:55
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Sep 8, 2021
@Tomanhez Tomanhez changed the title [WIP][CatalogPromotions][Api] Add test for creation rule [CatalogPromotions][Api] Add test for creation rule Sep 8, 2021
GSadee
GSadee reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I see that the validation message is displayed above the form: image

Can you do as it is for example on the cart promotion to be cosistent:
image
?

@GSadee GSadee merged commit d227d64 into Sylius:master Sep 10, 2021
@GSadee
Copy link
Member

GSadee commented Sep 10, 2021

Thank you, Tomasz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tomanhez @GSadee