Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotion] Improve names and namespaces of catalog promotion rule form types #13072

Merged
merged 1 commit into from
Sep 8, 2021
Merged

[CatalogPromotion] Improve names and namespaces of catalog promotion rule form types #13072

merged 1 commit into from
Sep 8, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Sep 8, 2021

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets after #13066 (review)
License MIT

@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Sep 8, 2021
@GSadee GSadee requested a review from a team as a code owner September 8, 2021 08:42
@lchrusciel lchrusciel merged commit 05b2ff4 into Sylius:master Sep 8, 2021
@lchrusciel
Copy link
Member

Thanks, Grzegorz! 🎉

@GSadee GSadee deleted the catalog-promotion-rule-form-types branch September 8, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GSadee @lchrusciel