[CatalogPromotions][Validation] add validation to catalog promotion, … #13093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirDomin
force-pushed
the
ui-actions-validation
branch
from
d5933d4
to
3fda132
Compare
…unify not number and empty amount
SirDomin
force-pushed
the
ui-actions-validation
branch
from
3fda132
to
4e69aa9
Compare
SirDomin
force-pushed
the
ui-actions-validation
branch
from
a4d2baf
to
b9d8046
Compare
AdamKasp
reviewed
Sep 13, 2021
src/Sylius/Bundle/PromotionBundle/Resources/translations/validators.en.yml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/Validator/Constraints/CatalogPromotionAction.php
Outdated
Show resolved
Hide resolved
Zales0123
reviewed
Sep 14, 2021
features/promotion/managing_catalog_promotions/validating_catalog_promotion_creation.feature
Outdated
Show resolved
Hide resolved
features/promotion/managing_catalog_promotions/validating_catalog_promotion_creation.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
...Bundle/PromotionBundle/Form/Type/CatalogAction/PercentageDiscountActionConfigurationType.php
Outdated
Show resolved
Hide resolved
SirDomin
force-pushed
the
ui-actions-validation
branch
from
f63ffdc
to
71af328
Compare
arti0090
approved these changes
Sep 14, 2021
| /** | ||
| * @Then I should be notified that a discount amount should be a number and cannot be empty | ||
| */ | ||
| public function iShouldBeNotifiedThatADiscountAmountShouldBeANumber(): void |
There was a problem hiding this comment.
Suggested change
| public function iShouldBeNotifiedThatADiscountAmountShouldBeANumber(): void | |
| public function iShouldBeNotifiedThatADiscountAmountShouldBeANumberAndCannotBeEmpty(): void |
GSadee
approved these changes
Sep 14, 2021
AdamKasp
approved these changes
Sep 14, 2021
|
Thank you, @SirDomin! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unify not number and empty amount