[API][CatalogPromotion] Reapplying catalog promotion on variant once its data changes #13128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Sep 21, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
arti0090
reviewed
Sep 21, 2021
| /** | ||
| * @When I look for a variant with :phrase in descriptor within the :product product | ||
| */ | ||
| public function iLookForVariantWithDescriptorWithinProduct($phrase, ProductInterface $product): void |
There was a problem hiding this comment.
Suggested change
| public function iLookForVariantWithDescriptorWithinProduct($phrase, ProductInterface $product): void | |
| public function iLookForVariantWithDescriptorWithinProduct(string $phrase, ProductInterface $product): void |
Also in other methods the type is missing 😢
There was a problem hiding this comment.
I've only changed the name of this file without any changes in it and I would like to leave it as it is in this PR 😃
GSadee
force-pushed
the
api-reapplying-catalog-promotions-variant
branch
2 times, most recently
from
23e543c
to
ee87b26
Compare
GSadee
changed the title
GSadee
force-pushed
the
api-reapplying-catalog-promotions-variant
branch
2 times, most recently
from
5f13790
to
b1de75c
Compare
AdamKasp
approved these changes
Sep 23, 2021
…variant once its data changes
…omotion on variant once its data changes
GSadee
force-pushed
the
api-reapplying-catalog-promotions-variant
branch
from
9473cac
to
394cf02
Compare
GSadee
force-pushed
the
api-reapplying-catalog-promotions-variant
branch
from
394cf02
to
79f417a
Compare
arti0090
approved these changes
Sep 24, 2021
Tomanhez
approved these changes
Sep 24, 2021
lchrusciel
approved these changes
Sep 24, 2021
|
Thank you, Grzegorz! 🎉 |
AdamKasp
added a commit
that referenced
this pull request
Sep 28, 2021
… variant once its data changes (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | based on #13128 | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- ada5870 [UI][CatalogPromotion] Reapply catalog promotion on variant once its data changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.