-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API][CatalogPromotion] Reapplying catalog promotion on variant once its data changes #13128
[API][CatalogPromotion] Reapplying catalog promotion on variant once its data changes #13128
Conversation
GSadee
commented
Sep 21, 2021
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Related tickets | |
License | MIT |
/** | ||
* @When I look for a variant with :phrase in descriptor within the :product product | ||
*/ | ||
public function iLookForVariantWithDescriptorWithinProduct($phrase, ProductInterface $product): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function iLookForVariantWithDescriptorWithinProduct($phrase, ProductInterface $product): void | |
public function iLookForVariantWithDescriptorWithinProduct(string $phrase, ProductInterface $product): void |
Also in other methods the type is missing 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only changed the name of this file without any changes in it and I would like to leave it as it is in this PR 😃
23e543c
to
ee87b26
Compare
5f13790
to
b1de75c
Compare
…variant once its data changes
…omotion on variant once its data changes
9473cac
to
394cf02
Compare
394cf02
to
79f417a
Compare
Thank you, Grzegorz! 🎉 |
… variant once its data changes (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | based on #13128 | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- ada5870 [UI][CatalogPromotion] Reapply catalog promotion on variant once its data changes