[API][UI] Toggle catalog promotion #13132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Sep 22, 2021
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
AdamKasp
force-pushed
the
toggle-enable-catalog-promotion
branch
2 times, most recently
from
6acc5ca
to
5fc4ea9
Compare
arti0090
reviewed
Sep 22, 2021
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
toggle-enable-catalog-promotion
branch
2 times, most recently
from
5db2a65
to
76f02bb
Compare
GSadee
reviewed
Sep 24, 2021
features/promotion/managing_catalog_promotions/creating_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
features/promotion/managing_catalog_promotions/creating_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
features/promotion/managing_catalog_promotions/editing_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
features/promotion/managing_catalog_promotions/editing_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Processor/CatalogPromotionProcessorSpec.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
toggle-enable-catalog-promotion
branch
from
76f02bb
to
43f10ad
Compare
GSadee
approved these changes
Sep 27, 2021
| * @Then /^("[^"]+" variant) and ("[^"]+" variant) should be discounted$/ | ||
| * @Then /^("[^"]+" variant) should be discounted$/ | ||
| */ | ||
| public function variantAndVariantShouldBeDiscounted(ProductVariantInterface ...$variants): void |
There was a problem hiding this comment.
I wonder if it won't be better to check that in admin endpoints 🤔
AdamKasp
force-pushed
the
toggle-enable-catalog-promotion
branch
from
43f10ad
to
f0229fd
Compare
|
Thanks, Adam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.