Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] change time format to 24H, autocomplete times on data change #13368

Merged
merged 2 commits into from
Dec 9, 2021
Merged

[UI] change time format to 24H, autocomplete times on data change #13368

merged 2 commits into from
Dec 9, 2021

Conversation

SirDomin
Copy link
Contributor

@SirDomin SirDomin commented Dec 8, 2021 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

Time display format has been changed to Y-m-d H:m from Y-m-d h:m:s, where s was 00 by default and h was 12h format, form takes seconds to account

Before:
image

After:
image

@SirDomin SirDomin requested a review from a team as a code owner December 8, 2021 03:43
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Dec 8, 2021
@SirDomin SirDomin added the UX Issues and PRs aimed at improving User eXperience. label Dec 8, 2021
@GSadee GSadee merged commit 65f7a4c into Sylius:master Dec 9, 2021
@GSadee
Copy link
Member

GSadee commented Dec 9, 2021

Thank you, @SirDomin! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamKasp AdamKasp AdamKasp left review comments

@GSadee GSadee GSadee approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SirDomin @GSadee @lchrusciel @AdamKasp