Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shop][API] Contract tests for an Address resource, customer authorization refactor #13409

Merged
merged 1 commit into from
Dec 21, 2021
Merged

[Shop][API] Contract tests for an Address resource, customer authorization refactor #13409

merged 1 commit into from
Dec 21, 2021

Conversation

Rafikooo
Copy link
Contributor

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

@Rafikooo Rafikooo added the API APIs related issues and PRs. label Dec 21, 2021
@Rafikooo Rafikooo requested a review from a team as a code owner December 21, 2021 10:47
lchrusciel
lchrusciel approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract address tests to a separate folder?

@lchrusciel lchrusciel merged commit 46c1f1b into Sylius:1.11 Dec 21, 2021
@lchrusciel
Copy link
Member

Thanks, Rafał! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@GSadee GSadee Awaiting requested review from GSadee

@AdamKasp AdamKasp Awaiting requested review from AdamKasp

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rafikooo @lchrusciel