Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old Kernel class from core bundle #13524

Closed
mmenozzi opened this issue Jan 24, 2022 · 0 comments · Fixed by #13531
Closed

Remove old Kernel class from core bundle #13524

mmenozzi opened this issue Jan 24, 2022 · 0 comments · Fixed by #13531
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Comments

@mmenozzi
Copy link
Contributor

The old Kernel class Sylius\Bundle\CoreBundle\Application\Kernel is deprecated since Sylius 1.3. This class uses symbols from old dependencies, some of them discontinued.
With #10664 we had to whitelist the those symbols due to this old Kernel class.

It's true that removing this class would be a BC break but it's also true that this class is deprecated since Sylius 1.3 and no one with a "modern" version of Sylius should be using it.

I propose to remove it, highlight its removal in the changelog and remove from ComposerRequireChecker whitelist its used symbols.
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Jan 24, 2022
@mmenozzi
Remove Sylius < 1.3 old Kernel class (Sylius#13524)
6508895
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Jan 24, 2022
@mmenozzi
Remove Sylius < 1.3 old Kernel class (Sylius#13524)
060df36
@mmenozzi mmenozzi mentioned this issue Jan 24, 2022
Merged
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Jan 24, 2022
@mmenozzi
Remove Sylius < 1.3 old Kernel class (Sylius#13524)
54805be
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Jan 25, 2022
@mmenozzi
Remove broken methods from Sylius < 1.3 old Kernel class (Sylius#13524)
b477812
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Jan 26, 2022
@mmenozzi
Deprecate and move public constants from old Sylius < 1.3 Kernel (Syl…
83dadeb 
…ius#13524)
@CoderMaggie CoderMaggie added DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Jan 26, 2022
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Feb 4, 2022
@mmenozzi
Deprecate and move public constants from old Sylius < 1.3 Kernel (Syl…
bfea0db 
…ius#13524)
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Feb 4, 2022
@mmenozzi
Add final to old Sylius Kernel class (Sylius#13524)
4a595b4
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Feb 4, 2022
@mmenozzi
Remove broken methods from Sylius < 1.3 old Kernel class (Sylius#13524)
f43c86c
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Feb 4, 2022
@mmenozzi
Deprecate and move public constants from old Sylius < 1.3 Kernel (Syl…
7240450 
…ius#13524)
mmenozzi added a commit to mmenozzi/Sylius that referenced this issue Feb 4, 2022
@mmenozzi
Add final to old Sylius Kernel class (Sylius#13524)
5906f01
GSadee added a commit that referenced this issue May 11, 2022
@GSadee
refactor #13531 Remove Sylius < 1.3 old Kernel class (#13524) (mmenoz…
3389c71 
…zi, TheMilek)

This PR was merged into the 1.12-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #13524 
| License         | MIT


Commits
-------

f43c86c Remove broken methods from Sylius < 1.3 old Kernel class (#13524)
7240450 Deprecate and move public constants from old Sylius < 1.3 Kernel (#13524)
5906f01 Add final to old Sylius Kernel class (#13524)
e68f244 Merge branch 'master' into issue-13524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Sylius < 1.3 old Kernel class (#13524) mmenozzi/Sylius
2 participants
@mmenozzi @CoderMaggie