Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Shipping methods resolution #13628

Merged
merged 7 commits into from Feb 18, 2022
Merged

[API] Shipping methods resolution #13628

merged 7 commits into from Feb 18, 2022

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Feb 9, 2022 •
edited

Q A
Branch? master
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
License MIT

ShippingMethods as an subresource was causing unwanted behaviour - we decided to make it into a collection to solve the problem

@TheMilek TheMilek requested a review from a team as a code owner February 9, 2022 16:44
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Feb 9, 2022
@TheMilek TheMilek changed the title [WIP] Shipping methods resolution [WIP][API] Shipping methods resolution Feb 9, 2022
@TheMilek TheMilek force-pushed the shipping-methods-resolution branch 5 times, most recently from 3ed0200 to 048775f Compare February 10, 2022 08:26
AdamKasp
AdamKasp reviewed Feb 10, 2022
View reviewed changes
...shipping_method_rules/viewing_available_shipping_methods_based_on_channel_as_a_guest.feature Outdated Show resolved Hide resolved
...d_rules/viewing_available_shipping_methods_based_on_channel_as_an_logged_in_customer.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Resources/config/services/api.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/CartShippingMethodsCollectionDataProvider.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/CartShippingMethodsCollectionDataProvider.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Serializer/ShippingMethodNormalizer.php Outdated
Comment on lines 35 to 37
private OrderRepositoryInterface $orderRepository,
private ShipmentRepositoryInterface $shipmentRepository,
private ServiceRegistryInterface $shippingCalculators
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you change it?

src/Sylius/Bundle/ApiBundle/Serializer/ShippingMethodNormalizer.php Outdated Show resolved Hide resolved
@TheMilek TheMilek force-pushed the shipping-methods-resolution branch 3 times, most recently from 02e8e01 to 5d51e6a Compare February 10, 2022 14:03
@TheMilek TheMilek changed the title [WIP][API] Shipping methods resolution [API] Shipping methods resolution Feb 10, 2022
AdamKasp
AdamKasp reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@AdamKasp AdamKasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please remove wip flag from your commits

src/Sylius/Bundle/ApiBundle/DataProvider/CartShippingMethodsCollectionDataProvider.php Outdated Show resolved Hide resolved
@TheMilek TheMilek force-pushed the shipping-methods-resolution branch 2 times, most recently from e5fbb51 to ed19222 Compare February 10, 2022 15:23
@TheMilek TheMilek force-pushed the shipping-methods-resolution branch 2 times, most recently from 09128b2 to 605a8e0 Compare February 10, 2022 16:37
GSadee
GSadee reviewed Feb 10, 2022
View reviewed changes
...hipping/viewing_shipping_methods/viewing_available_shipping_methods_based_on_channel.feature Outdated Show resolved Hide resolved
...hipping/viewing_shipping_methods/viewing_available_shipping_methods_based_on_channel.feature Outdated Show resolved Hide resolved
...hipping/viewing_shipping_methods/viewing_available_shipping_methods_based_on_channel.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Shop/CheckoutContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/ShippingContext.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/CartShippingMethodsCollectionDataProvider.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/CartShippingMethodsCollectionDataProvider.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Filter/ShippingMethodFilter.php Outdated Show resolved Hide resolved
@TheMilek TheMilek force-pushed the shipping-methods-resolution branch 2 times, most recently from d536811 to cde0e99 Compare February 11, 2022 08:16
@TheMilek TheMilek changed the base branch from 1.11 to master February 15, 2022 10:39
@TheMilek TheMilek force-pushed the shipping-methods-resolution branch 3 times, most recently from 440bc98 to 6e1e8f9 Compare February 15, 2022 17:15
@TheMilek TheMilek force-pushed the shipping-methods-resolution branch 2 times, most recently from e1a6906 to dd1a1dd Compare February 16, 2022 07:27
@TheMilek TheMilek mentioned this pull request Feb 17, 2022
Merged
@lchrusciel lchrusciel merged commit ea46445 into Sylius:master Feb 18, 2022
@lchrusciel
Copy link
Member

Thank you, Kamil! 🎉

GSadee added a commit that referenced this pull request Feb 23, 2022
@GSadee
minor #13659 API Upgrade file updated after ShippingMethod endpoints …
584bc76 
…changes (TheMilek)

This PR was merged into the 1.12-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | #13628
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

2ee5438 information about shippingMethods endpoints changes documented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@Zales0123 Zales0123 Zales0123 left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TheMilek @lchrusciel @GSadee @Zales0123 @AdamKasp