API Upgrade file updated after ShippingMethod endpoints changes #13659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Feb 17, 2022
TheMilek
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Related tickets | #13628 |
| License | MIT |
probot-autolabeler
bot
added
the
Maintenance
TheMilek
changed the title
lchrusciel
reviewed
Feb 18, 2022
TheMilek
force-pushed
the
shipping-methods-shop-endpoints-refactor-documented
branch
from
8f8b6ff
to
6f8185c
Compare
GSadee
reviewed
Feb 18, 2022
TheMilek
force-pushed
the
shipping-methods-shop-endpoints-refactor-documented
branch
2 times, most recently
from
4d08c8a
to
00da7d1
Compare
AdamKasp
approved these changes
Feb 22, 2022
Rafikooo
approved these changes
Feb 22, 2022
SirDomin
approved these changes
Feb 22, 2022
TheMilek
force-pushed
the
shipping-methods-shop-endpoints-refactor-documented
branch
from
00da7d1
to
2ee5438
Compare
Rafikooo
approved these changes
Feb 22, 2022
AdamKasp
reviewed
Feb 23, 2022
Comment on lines
+22
to
+60
| Here is how the response looks like: | ||
|
|
||
| ``` | ||
| { | ||
| "@context": "/api/v2/contexts/ShippingMethod", | ||
| "@id": "/api/v2/shop/shipping-methods", | ||
| "@type": "hydra:Collection", | ||
| "hydra:member": [ | ||
| { | ||
| "@id": "/api/v2/shop/shipping-methods/ups", | ||
| "@type": "ShippingMethod", | ||
| "id": 1, | ||
| "code": "ups", | ||
| "position": 0, | ||
| "name": "UPS", | ||
| "description": "Quasi perferendis debitis officiis ut inventore exercitationem." | ||
| } | ||
| ], | ||
| "hydra:totalItems": 1, | ||
| "hydra:search": { | ||
| "@type": "hydra:IriTemplate", | ||
| "hydra:template": "/api/v2/shop/shipping-methods{?shipmentId,tokenValue}", | ||
| "hydra:variableRepresentation": "BasicRepresentation", | ||
| "hydra:mapping": [ | ||
| { | ||
| "@type": "IriTemplateMapping", | ||
| "variable": "shipmentId", | ||
| "property": null, | ||
| "required": false | ||
| }, | ||
| { | ||
| "@type": "IriTemplateMapping", | ||
| "variable": "tokenValue", | ||
| "property": null, | ||
| "required": false | ||
| } | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
IMHO this example is not necessary
|
Thank you, Kamil! 🎉 |
lchrusciel
added a commit
that referenced
this pull request
Mar 17, 2022
This PR was merged into the 1.12-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master <!-- see the comment below --> | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | PR #13659 #13636 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> There was a wrong parameter names provided in our API UPGRADE file that could cause misunderstanding of the new endpoints Commits ------- 0d542cb UPGRADE file parameter names fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.