[Payment method] Listing payment method #13636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKasp
force-pushed
the
listing-payment-method
branch
from
a46be9d
to
88724af
Compare
AdamKasp
force-pushed
the
listing-payment-method
branch
from
88724af
to
88b0569
Compare
probot-autolabeler
bot
added
the
Maintenance
AdamKasp
changed the title
Roshyo
reviewed
Feb 18, 2022
GSadee
reviewed
Feb 18, 2022
...checkout/paying_for_order/viewing_available_payment_methods_based_on_current_channel.feature
Outdated
Show resolved
Hide resolved
...checkout/paying_for_order/viewing_available_payment_methods_based_on_current_channel.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutPaymentContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/PaymentMethodsCollectionDataProvider.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
listing-payment-method
branch
from
88b0569
to
6c68669
Compare
probot-autolabeler
bot
added
the
Documentation
AdamKasp
force-pushed
the
listing-payment-method
branch
3 times, most recently
from
1eefbc9
to
2ce1b86
Compare
lchrusciel
reviewed
Feb 23, 2022
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutPaymentContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutPaymentContext.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
listing-payment-method
branch
from
2ce1b86
to
dc01004
Compare
AdamKasp
force-pushed
the
listing-payment-method
branch
from
dc01004
to
01b73eb
Compare
lchrusciel
approved these changes
Feb 23, 2022
|
Thank you, Adam! 🥇 |
GSadee
reviewed
Feb 24, 2022
| But I should not see "Bank of Poland" and "Bank of Universe" payment methods | ||
|
|
||
| @api @ui | ||
| Scenario: Seeing shipping methods that are available in another channel as an logged in customer |
| But I should not see "Bank of Poland" and "Bank of Universe" payment methods | ||
|
|
||
| @ui @api | ||
| Scenario: Seeing shipping methods that are available in another channel as a guest |
lchrusciel
added a commit
that referenced
this pull request
Mar 17, 2022
This PR was merged into the 1.12-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master <!-- see the comment below --> | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | PR #13659 #13636 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> There was a wrong parameter names provided in our API UPGRADE file that could cause misunderstanding of the new endpoints Commits ------- 0d542cb UPGRADE file parameter names fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Api we should have a unified way to get valid payment methods