Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance]Run schema validation on mysql pipeline #13847

Merged
merged 2 commits into from
May 4, 2022

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Apr 7, 2022

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets PR
License MIT

The PR should be failing, but after the #13846 it should be nice and green :)

This is what happened here. Cherry-pick the change from #13846 that all database pipelines were failing. What I found is that we actually test the schema, but accept failing steps. By not accepting that we were able to find out the problem with some extra things. Like our PostgreSQL schema is successfully validated, but our MariaDB schema is not. That's because of JSON type and the difference between MySQL and MariaDB. Now we have to decide whether we want these two schemas to be up to date or we turn off migrations on MariaDB

@Ferror Ferror requested a review from a team as a code owner April 7, 2022 14:10
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Apr 7, 2022
@Ferror
Copy link
Contributor Author

Ferror commented Apr 7, 2022

@lchrusciel ready

Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Zbychu,

can you cherry-pick #13846 commit to your work, so we can merge it all together and check the correctness of the solution?

Comment on lines -10 to -12
driver: 'pdo_mysql'
server_version: '5.7'
charset: utf8mb4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ferror Ferror force-pushed the pipeline-schema-validate branch 3 times, most recently from 776dc88 to f7388c1 Compare April 12, 2022 15:33
@lchrusciel lchrusciel changed the base branch from master to 1.11 April 13, 2022 08:51
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "pipeline-schema-validate" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel
Copy link
Member

I've switched to 1.11 to fix existing release with patch

@lchrusciel lchrusciel added Environment Environment (OS, databases, libraries, etc.) specific issues. Bug Confirmed bugs or bugfixes. labels May 4, 2022
@lchrusciel lchrusciel merged commit 65ed981 into Sylius:1.11 May 4, 2022
@Ferror Ferror deleted the pipeline-schema-validate branch May 4, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Environment Environment (OS, databases, libraries, etc.) specific issues. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants