-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maintenance]Run schema validation on mysql pipeline #13847
Conversation
@lchrusciel ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Zbychu,
can you cherry-pick #13846 commit to your work, so we can merge it all together and check the correctness of the solution?
59b8c71
to
a372dcb
Compare
driver: 'pdo_mysql' | ||
server_version: '5.7' | ||
charset: utf8mb4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont need to specify that as of https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#automatic-platform-version-detection
776dc88
to
f7388c1
Compare
f7388c1
to
611afcc
Compare
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
I've switched to 1.11 to fix existing release with patch |
The PR should be failing, but after the #13846 it should be nice and green :)
This is what happened here. Cherry-pick the change from #13846 that all database pipelines were failing. What I found is that we actually test the schema, but accept failing steps. By not accepting that we were able to find out the problem with some extra things. Like our PostgreSQL schema is successfully validated, but our MariaDB schema is not. That's because of JSON type and the difference between MySQL and MariaDB. Now we have to decide whether we want these two schemas to be up to date or we turn off migrations on MariaDB