Update messenger table if table exist #13846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
delyriand
commented
Apr 7, 2022
delyriand
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #13838 |
| License | MIT |
|
Hey Maxime, thanks a lot for your contribution. Do you know, why we didn't catch it up with our workflow? Can we improve our tests to avoid regression in the future? |
|
I don't know why your workflow don't catch this error. Because in your |
|
Ok, PostgreSQL is not working, MariaDB is throwing erros: and we don't test it on MySQL.... |
|
@lchrusciel I will open PR with schema validation on pipelines |
wadjeroudi
approved these changes
Apr 9, 2022
lchrusciel
added a commit
that referenced
this pull request
May 4, 2022
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | [PR](#13846) | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> The PR should be failing, but after the #13846 it should be nice and green :) This is what happened here. Cherry-pick the change from #13846 that all database pipelines were failing. What I found is that we actually test the schema, but accept failing steps. By not accepting that we were able to find out the problem with some extra things. Like our PostgreSQL schema is successfully validated, but our MariaDB schema is not. That's because of JSON type and the difference between MySQL and MariaDB. Now we have to decide whether we want these two schemas to be up to date or we turn off migrations on MariaDB Commits ------- 91d5a94 [Maintenance]Run schema validation on mysql pipeline 611afcc fix(migration): update messenger table if table exist
|
Closing as it was already fixed in Sylius v1.11.5 |
Zales0123
pushed a commit
to Sylius/SyliusCoreBundle
that referenced
this pull request
Jun 2, 2022
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | [PR](Sylius/Sylius#13846) | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> The PR should be failing, but after the Sylius/Sylius#13846 it should be nice and green :) This is what happened here. Cherry-pick the change from #13846 that all database pipelines were failing. What I found is that we actually test the schema, but accept failing steps. By not accepting that we were able to find out the problem with some extra things. Like our PostgreSQL schema is successfully validated, but our MariaDB schema is not. That's because of JSON type and the difference between MySQL and MariaDB. Now we have to decide whether we want these two schemas to be up to date or we turn off migrations on MariaDB Commits ------- 91d5a94 [Maintenance]Run schema validation on mysql pipeline 611afcc fix(migration): update messenger table if table exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.