Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.11][User] Reduce usage of deprecated \Serializable interface #13642 #13921

Merged
merged 1 commit into from
May 6, 2022
Merged

[1.11][User] Reduce usage of deprecated \Serializable interface #13642 #13921

merged 1 commit into from
May 6, 2022

Conversation

sad270
Copy link
Contributor

@sad270 sad270 commented May 2, 2022

Remove deprecated message of \Serializable interface in User entity which is reported in PHP 8.1.

Deprecated: Sylius\Component\User\Model\User implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /srv/acme/vendor/sylius/sylius/src/Sylius/Component/User/Model/User.php on line 21
  • Added new __serialize and __unserialize methods to cover serialization
  • Made serialize and unserialize internal to prevent usage of them (we can remove in next version).
Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no/yes
Related tickets #13642
License MIT

@sad270 sad270 requested a review from a team as a code owner May 2, 2022 23:43
@sad270 sad270 requested a review from loic425 May 4, 2022 07:41
@loic425
Copy link
Member

loic425 commented May 4, 2022

@lchrusciel I think we should base this PR on 1.11 branch, what do you think?

@sad270 sad270 changed the base branch from master to 1.11 May 5, 2022 07:57
@sad270 sad270 changed the base branch from 1.11 to master May 5, 2022 07:58
@sad270
Copy link
Contributor Author

sad270 commented May 5, 2022

@lchrusciel I think we should base this PR on 1.11 branch, what do you think?

Yes, there is no BC break. I don't see that I'm on the master. It's for 1.11 not for 1.12

@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "master" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel changed the base branch from master to 1.11 May 5, 2022 11:07
@lchrusciel lchrusciel added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels May 6, 2022
@lchrusciel lchrusciel merged commit f11f614 into Sylius:1.11 May 6, 2022
@lchrusciel
Copy link
Member

Thanks, Sadetdin! 🎉

@sad270
Copy link
Contributor Author

sad270 commented May 6, 2022 •
edited
Loading

@lchrusciel my terminal will thanks you for merging my PR :p
And my deprecation logs too

@loic425 loic425 mentioned this pull request May 16, 2022
Merged
lchrusciel added a commit that referenced this pull request May 27, 2022
@lchrusciel
refactor #13987 Remove custom error level on Phpspec (loic425)
e36ee6a 
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11
| Bug fix?        | no                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no
| Related tickets |     |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->

This is not needed anymore since #13921

Commits
-------

1009082 Remove custom error level on Phpspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@loic425 loic425 loic425 approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sad270 @loic425 @lchrusciel