[1.11][User] Reduce usage of deprecated \Serializable interface
#13642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stloyd
force-pushed
the
patch-10
branch
2 times, most recently
from
c1a238e
to
067d5b7
Compare
Replace usage of `serialize/unserialize` with `__serialize/__unserialize` methods
stloyd
changed the title
\Serializable interface\Serializable interface
stloyd
changed the title
\Serializable interface\Serializable interface
|
@stloyd you have a static check failing :) . This PR is nice for PHP 8.1 full support. +1 for it to be merged! (I'm not going to duplicate this time 🙈 ) |
Roshyo
approved these changes
Apr 6, 2022
sad270
reviewed
Apr 28, 2022
| */ | ||
| public function unserialize($serialized): void | ||
| { | ||
| $data = unserialize($serialized); | ||
| $data = (array) unserialize((string) $serialized); |
There was a problem hiding this comment.
Suggested change
| $data = (array) unserialize((string) $serialized); | |
| $data = unserialize($data); | |
| if (!is_array($data)) { | |
| throw new UnexpectedValueException(sprintf('Cannot deserialize %s instance', self::class)); | |
| } |
Should fix the Static checks.
sad270
reviewed
May 2, 2022
Comment on lines
+419
to
+427
| { | ||
| $this->password = $data['password'] ?? null; | ||
| $this->salt = $data['salt'] ?? null; | ||
| $this->usernameCanonical = $data['usernameCanonical'] ?? null; | ||
| $this->username = $data['username'] ?? null; | ||
| $this->locked = $data['locked'] ?? null; | ||
| $this->enabled = $data['enabled'] ?? null; | ||
| $this->id = $data['id'] ?? null; | ||
| $this->encoderName = $data['encoderName'] ?? null; |
There was a problem hiding this comment.
This will not work, when we serialize we don't return a associative array !
lchrusciel
added a commit
that referenced
this pull request
May 6, 2022
…e` interface #13642 (sad270) This PR was merged into the 1.11 branch. Discussion ---------- Remove deprecated message of `\Serializable` interface in `User` entity which is reported in PHP 8.1. ``` Deprecated: Sylius\Component\User\Model\User implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /srv/acme/vendor/sylius/sylius/src/Sylius/Component/User/Model/User.php on line 21 ``` - Added new `__serialize` and `__unserialize` methods to cover serialization - Made `serialize` and `unserialize` internal to prevent usage of them (we can remove in next version). | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no/yes | | Related tickets | #13642 | | License | MIT | Commits ------- c94092c [User] Remove deprecated `\Serializable` interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce usage of deprecated
\Serializableinterface which is reported in PHP 8.1.Added new
__serialize/__unserializemethods to cover serialization & madeserialize/unserializeinternal to prevent usage of them (we can remove in next version).