Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat][Fix] Check notification expectation in JavaScriptTestHelper #14301

Merged
merged 1 commit into from
Sep 15, 2022
Merged

[Behat][Fix] Check notification expectation in JavaScriptTestHelper #14301

merged 1 commit into from
Sep 15, 2022

Conversation

Rafikooo
Copy link
Contributor

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Fixes:
image

Before:
image

After:
image

Mentioned here: #14291 (comment)

@Rafikooo Rafikooo requested a review from a team as a code owner September 14, 2022 11:38
@Rafikooo Rafikooo mentioned this pull request Sep 15, 2022
Merged
@GSadee GSadee added the Behat Issues and PRs aimed at improving Behat usage. label Sep 15, 2022
@GSadee GSadee merged commit dce55b8 into Sylius:1.11 Sep 15, 2022
@GSadee
Copy link
Member

GSadee commented Sep 15, 2022

Thanks, Rafał! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rafikooo @GSadee