Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotions][UI] Removal of catalog promotions #14291

Merged
merged 2 commits into from
Sep 16, 2022
Merged

[CatalogPromotions][UI] Removal of catalog promotions #14291

merged 2 commits into from
Sep 16, 2022

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented Sep 8, 2022 •
edited
Loading

Q A
Branch? 1.12
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets #14270
License MIT

image

@Rafikooo Rafikooo added the Feature New feature proposals. label Sep 8, 2022
@Rafikooo Rafikooo requested a review from a team as a code owner September 8, 2022 11:03
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. labels Sep 8, 2022
@Rafikooo Rafikooo changed the title [WIP][CatalogPromotions][UI] Removal of catalog promotions [CatalogPromotions][UI] Removal of catalog promotions Sep 9, 2022
@Rafikooo Rafikooo mentioned this pull request Sep 14, 2022
Merged
GSadee added a commit that referenced this pull request Sep 15, 2022
@GSadee
bug #14301 [Behat][Fix] Check notification expectation in JavaScriptT…
dce55b8 
…estHelper (Rafikooo)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11 <!-- see the comment below -->                  |
| Bug fix?        | yes                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file --> |
| License         | MIT                                                          |

Fixes:
<img width="853" alt="image" src="https://user-images.githubusercontent.com/40125720/190143519-a8030a24-3fa5-4075-8fe2-ab74c0c0409a.png">

Before:
<img width="714" alt="image" src="https://user-images.githubusercontent.com/40125720/190143668-e7ebd093-623c-48cc-8cbd-d55d0365bd87.png">

After:
<img width="1431" alt="image" src="https://user-images.githubusercontent.com/40125720/190143782-b4e07141-61f7-4e07-95a4-6bfe9fd6c041.png">



Mentioned here: #14291 (comment)

Commits
-------

4769726 [Behat][Fix] Check notification expectation in JavaScriptTestHelper
Rafikooo
Rafikooo commented Sep 15, 2022
View reviewed changes
src/Sylius/Bundle/AdminBundle/Controller/RemoveCatalogPromotionAction.php
try {
$this->catalogPromotionRemovalProcessor->removeCatalogPromotion($request->attributes->get('code'));

/** @var Session $session */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I marked it as Session instead of SessionInterface and spit it into two statements is the lack of getFlashBag() method in the SessionInterface. Psalm was angry about it

@Rafikooo Rafikooo mentioned this pull request Sep 15, 2022
Merged
@GSadee GSadee merged commit e4b0bce into Sylius:1.12 Sep 16, 2022
@GSadee
Copy link
Member

GSadee commented Sep 16, 2022

Thanks, Rafał! 🎉

GSadee added a commit that referenced this pull request Sep 16, 2022
@GSadee
feature #14314 [CatalogPromotions][Docs] Removing of catalog promotio…
4f19c64 
…ns documented (Rafikooo)

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.12 <!-- see the comment below -->                  |
| Bug fix?        | no                                                       |
| New feature?    | yes                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | #14270 #14291
| License         | MIT                                                          |

<img width="791" alt="image" src="https://user-images.githubusercontent.com/40125720/190518685-4b30f80e-8c19-411f-ab15-6669318391a2.png">

<img width="799" alt="image" src="https://user-images.githubusercontent.com/40125720/190518521-82f1814d-6fc6-4d91-9702-b32c52f24c1e.png">



Commits
-------

620a7ba [CatalogPromotions][Docs] Removing of catalog promotions documented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp diimpp left review comments

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@coldic3 coldic3 coldic3 approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Rafikooo @GSadee @diimpp @NoResponseMate @coldic3