-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Remove migrating to webpack page from docs #14333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if there is any other documentation that needs to be adapted, I mean mainly template files and assets paths
I've rechecked and there are no mentions about node version or any related stuff so this PR is complete for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a PR for adjusting our docs after making webpack the default build tool, IMO you should adjust also getting started, installation guide and some places where assets are used as for example: https://docs.sylius.com/en/latest/getting-started-with-sylius/shop-customizations.html#logo
|
||
This chapter will introduce you to the world of Sylius' frontend. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Jakub! 🎉 |
Initially, I was planning to make a bigger section about our changes in frontend but I think the section from the
UPGRADE
file is more than enough (ref #14330).