Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove migrating to webpack page from docs #14333

Merged
merged 2 commits into from
Sep 29, 2022
Merged

[Docs] Remove migrating to webpack page from docs #14333

merged 2 commits into from
Sep 29, 2022

Conversation

jakubtobiasz
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Initially, I was planning to make a bigger section about our changes in frontend but I think the section from the UPGRADE file is more than enough (ref #14330).

@jakubtobiasz jakubtobiasz requested a review from a team as a code owner September 20, 2022 14:45
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Sep 20, 2022
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if there is any other documentation that needs to be adapted, I mean mainly template files and assets paths

docs/cookbook/frontend/map.rst.inc Show resolved Hide resolved
@jakubtobiasz
Copy link
Contributor Author

I've rechecked and there are no mentions about node version or any related stuff so this PR is complete for me.

Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a PR for adjusting our docs after making webpack the default build tool, IMO you should adjust also getting started, installation guide and some places where assets are used as for example: https://docs.sylius.com/en/latest/getting-started-with-sylius/shop-customizations.html#logo

@probot-autolabeler probot-autolabeler bot added Docker Docker-related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Sep 29, 2022
docs/book/frontend/managing-assets.rst Outdated Show resolved Hide resolved
docs/book/frontend/managing-assets.rst Outdated Show resolved Hide resolved
docs/book/frontend/overview.rst Outdated Show resolved Hide resolved
docs/book/index.rst Outdated Show resolved Hide resolved
docs/book/index.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/migrating-to-webpack.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/staying-with-gulp.rst Outdated Show resolved Hide resolved
docs/docker-compose.yml Outdated Show resolved Hide resolved

This chapter will introduce you to the world of Sylius' frontend.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@GSadee GSadee merged commit afa5e48 into Sylius:1.12 Sep 29, 2022
@GSadee
Copy link
Member

GSadee commented Sep 29, 2022

Thanks, Jakub! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Docker-related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants