[Maintenance] Allow to choose whether use Webpack or Gulp #14330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
Admin
jakubtobiasz
commented
Sep 20, 2022
jakubtobiasz
changed the title
This was referenced Sep 20, 2022
GSadee
reviewed
Sep 21, 2022
src/Sylius/Bundle/UiBundle/Resources/config/app/parameters.yaml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Resources/views/Layout/Header/_logo.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/views/Layout/_logo.html.twig
Outdated
Show resolved
Hide resolved
Ferror
reviewed
Sep 21, 2022
coldic3
reviewed
Sep 21, 2022
Zales0123
reviewed
Sep 22, 2022
src/Sylius/Bundle/UiBundle/Resources/config/app/parameters.yaml
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
Sep 22, 2022
lchrusciel
reviewed
Sep 22, 2022
NoResponseMate
approved these changes
Sep 23, 2022
src/Sylius/Bundle/AdminBundle/Resources/views/Security/_content.html.twig
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Góralski <jan.wojciech.goralski@gmail.com>
Co-authored-by: Jan Góralski <jan.wojciech.goralski@gmail.com>
GSadee
approved these changes
Sep 26, 2022
|
|
||
| If you decide to use Webpack, you need to follow the steps below: | ||
|
|
||
| 1. Make sure you have latest js dependencies installed (you can compare your `package.json` file with the one from `1.12`). |
There was a problem hiding this comment.
Suggested change
| 1. Make sure you have latest js dependencies installed (you can compare your `package.json` file with the one from `1.12`). | |
| 1. Make sure you have the latest js dependencies installed (you can compare your `package.json` file with the one from `1.12`). |
|
Thank you, Jakub! 🎉 |
GSadee
added a commit
that referenced
this pull request
Sep 29, 2022
…kubtobiasz) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | | | License | MIT | <!-- - Bug fixes must be submitted against the 1.11 branch - Features and deprecations must be submitted against the 1.12 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Initially, I was planning to make a bigger section about our changes in frontend but I think the section from the `UPGRADE` file is more than enough (ref #14330). Commits ------- 02d6a7b Remove migrating to webpack page from docs 8af27a6 Update documentation about Frontend
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
I've switched to webpack in every possible place. Also, I've replaced the old webpack test build with the gulp test build. Docs update is coming in the next PR.