Improve registration workflow #15056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubtobiasz
added
the
Enhancement
jakubtobiasz
force-pushed
the
registration-emails-fix
branch
5 times, most recently
from
96ab683
to
ba56339
Compare
AdamKasp
reviewed
Jun 23, 2023
src/Sylius/Behat/Page/Shop/Account/RegisterThankYouPageInterface.php
Outdated
Show resolved
Hide resolved
jakubtobiasz
force-pushed
the
registration-emails-fix
branch
from
d61ef59
to
91287bb
Compare
GSadee
reviewed
Aug 18, 2023
src/Sylius/Bundle/ApiBundle/CommandHandler/Account/VerifyCustomerAccountHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Controller/RegistrationThankYouController.php
Show resolved
Hide resolved
src/Sylius/Bundle/UiBundle/Resources/translations/messages.en.yml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/UiBundle/Resources/translations/messages.en.yml
Outdated
Show resolved
Hide resolved
jakubtobiasz
force-pushed
the
registration-emails-fix
branch
from
cadc387
to
45fcc1a
Compare
Bunnyshell Preview Environment deletedAvailable commands:
|
jakubtobiasz
force-pushed
the
registration-emails-fix
branch
2 times, most recently
from
1ed95f7
to
3d14418
Compare
probot-autolabeler
bot
added
the
Maintenance
jakubtobiasz
force-pushed
the
registration-emails-fix
branch
2 times, most recently
from
9d8a6ee
to
157a9f0
Compare
jakubtobiasz
force-pushed
the
registration-emails-fix
branch
from
157a9f0
to
474f12a
Compare
TheMilek
approved these changes
Aug 23, 2023
| * @Then I should be on my account dashboard | ||
| * @Then I should be on registration thank you page | ||
| */ | ||
| public function intentionallyLeftBlank(): void |
There was a problem hiding this comment.
I would stick to the convention of naming methods like we do in other steps, so make 2 blanks or one universal like
Suggested change
| public function intentionallyLeftBlank(): void | |
| public function iShouldBeOn(): void |
but still it's just a suggestion ✌🏽
NoResponseMate
approved these changes
Aug 24, 2023
|
/bns:deploy |
1 similar comment
|
/bns:deploy |
|
Thanks, Jacob! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased the PR, but couldn't push it due to permissions issues. I pushed the rebased branch onto my fork, and created this replacement PR (ofc. authorship behaved :))