Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant denormalization check #15595

Merged
merged 1 commit into from Dec 4, 2023

Conversation

jakubtobiasz
Copy link
Member

@jakubtobiasz jakubtobiasz commented Dec 4, 2023

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fix #15568
License MIT

This PR fixes a bug found by @GSadee while the QA check. Subresource-like endpoints have had populated the object to populate key, so they've been processed as usual. This PR applies our custom validation rules always when the input class is defined.
CleanShot 2023-12-04 at 16 57 32

@jakubtobiasz jakubtobiasz added the API APIs related issues and PRs. label Dec 4, 2023
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner December 4, 2023 12:54
Copy link

github-actions bot commented Dec 4, 2023

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@NoResponseMate NoResponseMate merged commit 5dedbcb into Sylius:1.13 Dec 4, 2023
25 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @jakubtobiasz!

@jakubtobiasz jakubtobiasz deleted the fix/SYL-3239 branch December 4, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants