Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ApiBundle] Update validation message for command argument types. #15568

Conversation

Wojdylak
Copy link
Member

@Wojdylak Wojdylak commented Nov 28, 2023

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

Before:
image
After:
image

@Wojdylak Wojdylak requested a review from a team as a code owner November 28, 2023 09:15
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Nov 28, 2023
Copy link

github-actions bot commented Nov 28, 2023

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@NoResponseMate NoResponseMate added the Bug Confirmed bugs or bugfixes. label Dec 1, 2023
@Wojdylak Wojdylak changed the title PoC: [ApiBundle] Update validation message for command argument types. [ApiBundle] Update validation message for command argument types. Dec 1, 2023
@NoResponseMate NoResponseMate merged commit 15ad91a into Sylius:1.13 Dec 1, 2023
25 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @Wojdylak!

@Wojdylak Wojdylak deleted the SYL-3239--api-validate-type-of-command-arguments branch December 1, 2023 10:23
NoResponseMate added a commit that referenced this pull request Dec 4, 2023
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fix #15568
| License         | MIT

This PR fixes a bug found by @GSadee while the QA check. Subresource-like endpoints have had populated the `object to populate` key, so they've been processed as usual. This PR applies our custom validation rules always when the `input` class is defined.
![CleanShot 2023-12-04 at 16 57 32](https://github.com/Sylius/Sylius/assets/80641364/a3cc7e11-c629-4344-bdbd-da7f41f818f5)
 

Commits
-------
  Remove redundant denormalization check
NoResponseMate added a commit that referenced this pull request Dec 8, 2023
…ng request field type (jakubtobiasz)

This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | improvement after #15568
| License         | MIT


Commits
-------
  Use serialized name when displaying an error about a wrong request field type
GSadee added a commit that referenced this pull request Jan 29, 2024
… (NoResponseMate)

This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 |
| Bug fix?        | yes                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no |
| Related tickets | related #14810, #15568, #15615                     |
| License         | MIT                                                          |

Commits
-------

b025de3 [Maintenance][API] Normalize command missing field name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants