-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ApiBundle] Update validation message for command argument types. #15568
Merged
NoResponseMate
merged 2 commits into
Sylius:1.13
from
Wojdylak:SYL-3239--api-validate-type-of-command-arguments
Dec 1, 2023
Merged
[ApiBundle] Update validation message for command argument types. #15568
NoResponseMate
merged 2 commits into
Sylius:1.13
from
Wojdylak:SYL-3239--api-validate-type-of-command-arguments
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deletedAvailable commands:
|
NoResponseMate
approved these changes
Dec 1, 2023
Thank you, @Wojdylak! |
NoResponseMate
added a commit
that referenced
this pull request
Dec 4, 2023
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fix #15568 | License | MIT This PR fixes a bug found by @GSadee while the QA check. Subresource-like endpoints have had populated the `object to populate` key, so they've been processed as usual. This PR applies our custom validation rules always when the `input` class is defined. ![CleanShot 2023-12-04 at 16 57 32](https://github.com/Sylius/Sylius/assets/80641364/a3cc7e11-c629-4344-bdbd-da7f41f818f5) Commits ------- Remove redundant denormalization check
NoResponseMate
added a commit
that referenced
this pull request
Dec 8, 2023
…ng request field type (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | improvement after #15568 | License | MIT Commits ------- Use serialized name when displaying an error about a wrong request field type
This was referenced Jan 26, 2024
GSadee
added a commit
that referenced
this pull request
Jan 29, 2024
… (NoResponseMate) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | related #14810, #15568, #15615 | | License | MIT | Commits ------- b025de3 [Maintenance][API] Normalize command missing field name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
![image](https://private-user-images.githubusercontent.com/33687392/286242820-b74e590d-a28b-4f5f-8e56-db68335fd9f2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU0MDMyNjcsIm5iZiI6MTcyNTQwMjk2NywicGF0aCI6Ii8zMzY4NzM5Mi8yODYyNDI4MjAtYjc0ZTU5MGQtYTI4Yi00ZjVmLThlNTYtZGI2ODMzNWZkOWYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAzVDIyMzYwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc0NTZiMDNmMjk5YWYwNjBmZWQwOTA5Yjk0ZjhlZDA1OGQ5MmY5ZWI1MWQ1ZjQ1ODc1ZjI3NzE3MzQ1Yjc5MTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lXs40cND_DBAoP8BgNKMIFc5PSi2ZyuOt9ksfwUTArs)
![image](https://private-user-images.githubusercontent.com/33687392/286242960-f682cb66-1f4e-435b-984d-c155eb7b0430.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU0MDMyNjcsIm5iZiI6MTcyNTQwMjk2NywicGF0aCI6Ii8zMzY4NzM5Mi8yODYyNDI5NjAtZjY4MmNiNjYtMWY0ZS00MzViLTk4NGQtYzE1NWViN2IwNDMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAzVDIyMzYwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUyNjU2NjY4ZGNhNWRhMTYxOTljNTc4ZWM5YzJhY2ZiYTVkNjIzMDk2MWRhMWNiYzg0ZDcxZTQzMzJmMmVmOGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.s9eEU0Mr4fffgLkEClZI-g2Y30GUDW_Ym3P7Di5O9ek)
After: