Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Drop custom uploading & use something "better" #1561

Closed
stloyd opened this issue May 26, 2014 · 10 comments
Closed

[RFC] Drop custom uploading & use something "better" #1561

stloyd opened this issue May 26, 2014 · 10 comments
Labels
RFC Discussions about potential changes or new features. Stale Issues and PRs with no recent activity, about to be closed soon.

Comments

@stloyd
Copy link
Contributor

stloyd commented May 26, 2014

Hello guys & gals!

After holidays, I started to look at my not finished PRs, and I found that #1284, is good start, but not good way to fix the problem of uploading code.

I done some research, and found that VichUploaderBundle covers totally our needs, and does even more for us as it supports:

  • both ORM & ODM,
  • add some useful helpers for templating stuff,
  • supports few filesystem libs: Symfony Filesystem, Gaufrette, Flysystem
  • and is well tested + documented!

Any feedback is welcome as usually =)

@pjedrzejewski
Copy link
Member

How it looks with the plan to use some of the js upload scripts? Drag and drop etc.

@stloyd
Copy link
Contributor Author

stloyd commented May 26, 2014

@pjedrzejewski I don't think anything is blocking each other, I guess that with this change the javascript based upload (#492) could be even easier to handle, mainly cause this is about internal handling, and js is about frontend handling.

@stloyd stloyd mentioned this issue May 26, 2014
@kayue
Copy link
Contributor

kayue commented May 26, 2014

Will we support multiple image per product?

@stloyd
Copy link
Contributor Author

stloyd commented May 26, 2014

@kayue I would say it's probably possible already, but maybe not an easy task. But it's for sure possible to have O2M relation with that bundle.

@pjedrzejewski
Copy link
Member

We already have o2m relation on variants and images.

@arnolanglade
Copy link
Contributor

I have a quick to VichUploaderBundle, it seems interesting!

@pilot
Copy link
Contributor

pilot commented Jun 12, 2014

good bundle, but it represent just a server layer for the file uploads, but we still have a case with frontend version of file uploader is what about ask @pjedrzejewski and @kayue. This bundle doesn't cover it, so we should think about to find/create a frontend part of uploader with multiple uploads, drug-n-drop, ordering, etc. as well handle relation between server side layer VichUploaderBundle and frontend js library.

@patie
Copy link

patie commented Jun 24, 2014

what about 1up-lab/OneupUploaderBundle ?

@amdad
Copy link

amdad commented Dec 29, 2017

Hi guys!
Just to know. Is there any movement on this matter?

@pamil pamil added RFC Discussions about potential changes or new features. Stale Issues and PRs with no recent activity, about to be closed soon. and removed RFC Discussions about potential changes or new features. labels Feb 1, 2018
@stale stale bot closed this as completed Feb 9, 2018
@cirykpopeye
Copy link

I think this feature might be a good addition to the Sylius platform. Right now it's a pain to add multiple images, especially if you want to sort them afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Discussions about potential changes or new features. Stale Issues and PRs with no recent activity, about to be closed soon.
Projects
None yet
Development

No branches or pull requests

9 participants