Use the new State Machine abstraction #15738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jakubtobiasz
commented
Jan 17, 2024
jakubtobiasz
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | kinda |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | based on the #15729 |
| License | MIT |
probot-autolabeler
bot
added
Admin
Bunnyshell Preview Environment deletedAvailable commands:
|
jakubtobiasz
force-pushed
the
SYL-3284
branch
7 times, most recently
from
f28391f
to
eebd7f8
Compare
jakubtobiasz
force-pushed
the
SYL-3284
branch
3 times, most recently
from
11421b5
to
d4db541
Compare
jakubtobiasz
force-pushed
the
SYL-3284
branch
2 times, most recently
from
8c3fc7a
to
b1a1d7e
Compare
jakubtobiasz
force-pushed
the
SYL-3284
branch
from
e54bfc4
to
ab21735
Compare
Wojdylak
previously approved these changes
Jan 29, 2024
| /** | ||
| * @throws StateMachineExecutionException | ||
| */ | ||
| public function getTransitionFromState(object $subject, string $graphName, string $fromState): ?string |
There was a problem hiding this comment.
It's discussable. I've talked with Janek about it, and we agreed we should all talk about it. I'm in favor of leaving it as-is, and eventually change it later.
There was a problem hiding this comment.
We'll discuss it further at a later date, either way, if we'd want to revert it and keep the public => protected => private order that'll be fixed along with adding an ecs rule.
src/Sylius/Component/Core/Payment/Provider/OrderPaymentProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Abstraction/StateMachine/src/SymfonyWorkflowAdapter.php
Outdated
Show resolved
Hide resolved
Wojdylak
previously approved these changes
Jan 30, 2024
jakubtobiasz
force-pushed
the
SYL-3284
branch
from
6daaeb2
to
fb5e73c
Compare
Wojdylak
approved these changes
Jan 31, 2024
TheMilek
approved these changes
Jan 31, 2024
NoResponseMate
approved these changes
Jan 31, 2024
NoResponseMate
approved these changes
Jan 31, 2024
|
Thank you, @jakubtobiasz! |
NoResponseMate
added a commit
that referenced
this pull request
Feb 23, 2024
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #15738 | License | MIT The `apply` method in the sm.callback.cascade_transition class (\SM\Callback\CascadeTransitionCallback) has a `$soft` parameter, which defaults to true. When `$soft` is set to true, the method first checks if the transition can be applied without throwing an exception. So I have added checking to symfony workflow events. Commits ------- Remove missed sm.factory usages [Behat] Replace sm.factory to sylius_abstraction.state_machine [Workflow] Add check to verify if a transaction can be applied [Behat] Change workflow exception message [Api] Add OrderCancellationFailedException class [Api] Add PaymentCompletionFailedException class [Api] Add ProductReviewAcceptanceFailedException class [Api] Add ProductReviewRejectionFailedException class [StateMachine] Organize the interfaces in CompositeStateMachine class [Api] Remove unnecessary code [StateMachine] Use WorkflowExceptionInterface instead of InvalidArgumentException [StateMachine] Refactor CompositeStateMachine to use inline commands [Api] Add semi-generic exception StateMachineTransitionFailedException [Core][Workflow] Rename names of test functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.