Remove missed sm.factory usages #15858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
API
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
force-pushed
the
remove-missed-sm-factory-usages
branch
from
edb70ff
to
b1daaae
Compare
Rafikooo
reviewed
Feb 21, 2024
src/Sylius/Bundle/ApiBundle/Applicator/OrderStateMachineTransitionApplicator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Applicator/ProductReviewStateMachineTransitionApplicator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/EventListener/Workflow/Order/CancelOrderPaymentListener.php
Show resolved
Hide resolved
diimpp
previously approved these changes
Feb 22, 2024
src/Sylius/Abstraction/StateMachine/src/CompositeStateMachine.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Exception/OrderCancellationFailedException.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Applicator/PaymentStateMachineTransitionApplicator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/EventListener/Workflow/Order/CreatePaymentListenerSpec.php
Outdated
Show resolved
Hide resolved
Rafikooo
approved these changes
Feb 22, 2024
| $this->getStateMachine()->apply($review, ProductReviewTransitions::GRAPH, $transition); | ||
| $stateMachine = $this->getStateMachine(); | ||
|
|
||
| if (false === $stateMachine->can($review, ProductReviewTransitions::GRAPH, $transition)) { |
There was a problem hiding this comment.
Why is it better this way instead of just using a simple try-catch block?
There was a problem hiding this comment.
Because the try-catch block catches all exceptions from the Symfony workflow, and the method can only checks if a transition is possible. In the try-catch block, we always receive the same exception, whereas in the second case, we receive different exceptions if the method apply throws an exception.
NoResponseMate
approved these changes
Feb 23, 2024
|
Thank you, @Wojdylak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
applymethod in the sm.callback.cascade_transition class (\SM\Callback\CascadeTransitionCallback) has a$softparameter, which defaults to true. When$softis set to true, the method first checks if the transition can be applied without throwing an exception. So I have added checking to symfony workflow events.