Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded placeholder from zone's scope select #16226

Merged
merged 2 commits into from
May 7, 2024
Merged

Remove unneeded placeholder from zone's scope select #16226

merged 2 commits into from
May 7, 2024

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented May 7, 2024 •
edited
Loading

Q A
Branch? 1.12
Bug fix? a bit
New feature? no
BC breaks? no
License MIT

Screenshot 2024-05-07 at 12 05 25
Screenshot 2024-05-07 at 12 05 32

@TheMilek TheMilek added UX Issues and PRs aimed at improving User eXperience. Admin AdminBundle related issues and PRs. labels May 7, 2024
@TheMilek TheMilek requested review from a team as code owners May 7, 2024 10:06
@CoderMaggie
Copy link
Member

Shouldn't the translation key be removed also?

@TheMilek TheMilek changed the base branch from bootstrap-admin-panel to 1.13 May 7, 2024 10:17
@TheMilek TheMilek force-pushed the SYL-3200-remove-unneeded-placeholder-from-zone-scope branch from ffa08b2 to a353a97 Compare May 7, 2024 10:22
@TheMilek TheMilek changed the base branch from 1.13 to 1.12 May 7, 2024 10:22
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited
Loading

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@Wojdylak Wojdylak merged commit 9b7e954 into Sylius:1.12 May 7, 2024
28 checks passed
@Wojdylak
Copy link
Member

Wojdylak commented May 7, 2024

Thanks, @TheMilek 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wojdylak Wojdylak Wojdylak approved these changes

@mpysiak mpysiak mpysiak approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheMilek @CoderMaggie @Wojdylak @mpysiak