Fix wrong calculation of available stock during completing a payment #16307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
May 24, 2024
GSadee
commented
| Q | A |
|---|---|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | caused by #15280, fixes #16160, replaces #15688, closes #16258 |
| License | MIT |
GSadee
added
Admin
Bunnyshell Preview Environment deletedAvailable commands:
|
GSadee
force-pushed
the
SYL-3503-fix-wrong-calculation-of-available-stock
branch
from
3c5c15a
to
b584bc8
Compare
mpysiak
previously approved these changes
May 27, 2024
Wojdylak
previously approved these changes
May 28, 2024
..._orders/handling_order_payment/finalizing_order_payment_when_item_has_become_tracked.feature
Outdated
Show resolved
Hide resolved
… item that has become tracked
Wojdylak
approved these changes
May 28, 2024
mpysiak
approved these changes
May 29, 2024
src/Sylius/Component/Core/Inventory/Exception/NotEnoughUnitsOnHandException.php
Show resolved
Hide resolved
|
Thank you, @GSadee! |
NoResponseMate
added a commit
that referenced
this pull request
Jun 3, 2024
…tions changes (GSadee) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 1.12 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | after #16307 | License | MIT <!-- - Bug fixes must be submitted against the 1.12 or 1.13 branches - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- [Inventory] Adjust OrderInventoryOperator spec for exceptions changes
NoResponseMate
added a commit
that referenced
this pull request
Jun 3, 2024
…n by inventory exceptions (GSadee) This PR was merged into the 1.14 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 1.14 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Related tickets | after #16307 | License | MIT <!-- - Bug fixes must be submitted against the 1.12 or 1.13 branches - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- [Inventory] Deprecate extending \InvalidArgumentException by NotEnoughUnitsOnHandException and NotEnoughUnitsOnHoldException exceptions
NoResponseMate
added a commit
that referenced
this pull request
Jun 3, 2024
…ions (GSadee) This PR was merged into the 2.0 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 2.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | after #16307, related to #16333 | License | MIT <!-- - Bug fixes must be submitted against the 1.12 or 1.13 branches - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- [Inventory] Extend \RuntimeException by NotEnoughUnitsOnHandException and NotEnoughUnitsOnHoldException exceptions [Inventory] Adjust OrderInventoryOperator spec for exceptions changes
Wojdylak
added a commit
that referenced
this pull request
Jun 5, 2024
… availability for given order item (GSadee) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 1.12 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | after #16307 | License | MIT In order to make it easier to customise the logic for checking the available stock, I would like to extract it from the listener into a separate service. <!-- - Bug fixes must be submitted against the 1.12 or 1.13 branches - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- [Inventory] Extract service for checking reserved stock availability for given order item Add a note to UPGRADE file about changing PaymentPreCompleteListener's constructor [Inventory] Add a BC layer for refactored PaymentPreCompleteListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.