Prevent throwing 500 while finalizing an order when at least one item has become tracked #15280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakubtobiasz
commented
Sep 7, 2023
jakubtobiasz
commented
| Q | A |
|---|---|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | closes #10313 |
| License | MIT |
… has become tracked
jakubtobiasz
added
Admin
Bunnyshell Preview Environment deletedAvailable commands:
|
|
/bns:start |
GSadee
approved these changes
Sep 8, 2023
| /** | ||
| * @Then I should be notified that the order's payment could not be finalized due to insufficient stock | ||
| */ | ||
| public function iShouldBeNotifiedThatTheOrderSPaymentCouldNotBeFinalizedDueToInsufficientStock() |
There was a problem hiding this comment.
Suggested change
| public function iShouldBeNotifiedThatTheOrderSPaymentCouldNotBeFinalizedDueToInsufficientStock() | |
| public function iShouldBeNotifiedThatTheOrderSPaymentCouldNotBeFinalizedDueToInsufficientStock(): void |
|
/bns:start |
|
Thank you, Jacob! 🥇 |
NoResponseMate
added a commit
that referenced
this pull request
Jun 3, 2024
…ing a payment (GSadee) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 1.12 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | caused by #15280, fixes #16160, replaces #15688, closes #16258 | License | MIT <!-- - Bug fixes must be submitted against the 1.12 or 1.13 branches - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- Fix unexpected error about not enough stocks while completing the payment in the Admin Panel [Behat] Refactor scenarios for finalizing order's payment Add spec for PaymentPreCompleteListener with minor improvements [Behat] Cover scenarios for finalizing order's payment in API [Inventory] Introduce custom exceptions for inventory operations [Behat] Adjust scenario and feature names for finalizing payment with item that has become tracked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.