Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookbook error advanced-sylius-cloud-configuration.rst #16390

Closed
TakesTheBiscuit opened this issue Jun 12, 2024 · 1 comment
Closed

Cookbook error advanced-sylius-cloud-configuration.rst #16390

TakesTheBiscuit opened this issue Jun 12, 2024 · 1 comment

Comments

@TakesTheBiscuit
Copy link

Sylius docs version: latest

Description
https://github.com/Sylius/Sylius/blob/1.14/docs/cookbook/deployment/advanced-sylius-cloud-configuration.rst

I think the CRONS section is wrong

crons:
    cancel-unpaid-orders:
        spec: "0 2 * * *"
        cmd: "php bin/console sylius:cancel-unpaid-orders"
    generate-promotion-coupons:
        spec: "0 2 * * *"
        cmd: "php bin/console sylius:promotion:generate-coupons"
    remove-expired-carts:
        spec: "0 2 * * *"
        cmd: "php bin/console sylius:cancel-unpaid-orders"

Should it be:

crons:
    cancel-unpaid-orders:
        spec: "0 2 * * *"
        cmd: "php bin/console sylius:cancel-unpaid-orders"
    generate-promotion-coupons:
        spec: "0 2 * * *"
        cmd: "php bin/console sylius:promotion:generate-coupons"
    remove-expired-carts:
        spec: "0 2 * * *"
        cmd: "php bin/console >??? sylius:remove-expired-carts ??? <"
@vvasiloi
Copy link
Contributor

@TakesTheBiscuit could you elaborate on your suggested change?

@TheMilek TheMilek mentioned this issue Jun 19, 2024
Merged
GSadee added a commit that referenced this issue Jun 19, 2024
@GSadee
minor #16439 Correct wrong command in the platform's cron example doc…
4943021 
…s (TheMilek)

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.12 <!-- see the comment below -->
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Related tickets | fixes[#X](#16390)
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.12 or 1.13 branches
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

e091878 Correct wrong command in the platform's cron example docs
@GSadee GSadee closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GSadee @vvasiloi @TakesTheBiscuit