Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payum payment description not customisable / translatable #7971

Closed
2 tasks
stefandoorn opened this issue Apr 21, 2017 · 0 comments · Fixed by #7979
Closed
2 tasks

Payum payment description not customisable / translatable #7971

stefandoorn opened this issue Apr 21, 2017 · 0 comments · Fixed by #7979
Labels
Feature New feature proposals.
Milestone

Comments

@stefandoorn
Copy link
Contributor

In sylius/sylius/src/Sylius/Bundle/PayumBundle/Action/CapturePaymentAction.php the following can be found:

$payumPayment->setDescription(sprintf(
                    'Payment contains %d items for a total of %01.2f',
                    $order->getItems()->count(),
                    round($totalAmount / 100, 2)
                ));

This is also something some of the clients see in the end, but it's also not translatable and/or configurable right now.

I think two things should be possible:

  • Make it customisable (multiple placeholders possible?)
  • Make it translatable

I would e.g. like a description like: 'Payment %websiteName% order %orderId%' or something like that.

We have the possibility to override the action of course, but I think this is a very common case lots of people will run into.

@pjedrzejewski pjedrzejewski added the Feature New feature proposals. label Apr 21, 2017
@pjedrzejewski pjedrzejewski added this to the v1.0.0 milestone Apr 21, 2017
stefandoorn added a commit to stefandoorn/Sylius that referenced this issue Apr 24, 2017
stefandoorn added a commit to stefandoorn/Sylius that referenced this issue Apr 25, 2017
stefandoorn added a commit to stefandoorn/Sylius that referenced this issue Apr 25, 2017
stefandoorn added a commit to stefandoorn/Sylius that referenced this issue May 9, 2017
stefandoorn added a commit to stefandoorn/Sylius that referenced this issue May 9, 2017
stefandoorn added a commit to stefandoorn/Sylius that referenced this issue May 9, 2017
lchrusciel added a commit that referenced this issue May 9, 2017
…ption

Payment description configurable with translation and placeholders (#7971)
pjedrzejewski pushed a commit to Sylius/SyliusPayumBundle that referenced this issue May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature proposals.
Projects
None yet
2 participants