Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Cleaner separation between Sylius and Sylius-Standard #9305

Closed
teohhanhui opened this issue Apr 5, 2018 · 7 comments
Closed

[RFC] Cleaner separation between Sylius and Sylius-Standard #9305

teohhanhui opened this issue Apr 5, 2018 · 7 comments
Labels
Do not stale Important issues and PRs, that should not be stalled by Stale Bot DX Issues and PRs aimed at improving Developer eXperience. RFC Discussions about potential changes or new features.

Comments

@teohhanhui
Copy link
Contributor

Q A
Bug report? no
Feature request? no
BC Break report? no
RFC? yes
Sylius version future major

Currently, many files exist in the Sylius repository that are only useful for the Sylius-Standard repository. This means the two projects are tightly coupled in a convoluted way. Issues like #9301 and #9304 cannot be properly fixed, because of the lack of a clean separation. Of course, this also makes it almost impossible to move to Symfony Flex (correct me if I'm wrong).

@pamil pamil added the RFC Discussions about potential changes or new features. label Apr 6, 2018
@pamil
Copy link
Contributor

pamil commented Apr 6, 2018

Apart of them being useful in Sylius-Standard, we also need them to test the whole application using Behat. I'm not sure if I understand Symfony Flex issue correctly, but it's mostly connected to single bundles, not the whole application, so this should be possible just by customising them.

@teohhanhui
Copy link
Contributor Author

@pamil Continuing the discussion here.

We could start by getting rid of the shared Kernel, or if there's a need for some extended functionality, making sure that whatever is in it is not related to the "app" / distribution.

@teohhanhui
Copy link
Contributor Author

Apart of them being useful in Sylius-Standard, we also need them to test the whole application using Behat.

The test app should have its own AppKernel. Yes, there will be some duplication, but it's necessary. :)

@teohhanhui
Copy link
Contributor Author

teohhanhui commented Apr 12, 2018

Also, all the XXXBundle/Resources/app/config.yml and such should definitely be moved to Sylius-Standard.

Say, normally these issues would be fixed in Sylius-Standard, not Sylius:

@stale
Copy link

stale bot commented Jul 15, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Jul 15, 2018
@stale stale bot closed this as completed Jul 22, 2018
@pamil pamil reopened this Jul 23, 2018
@stale stale bot removed the Stale Issues and PRs with no recent activity, about to be closed soon. label Jul 23, 2018
@pamil pamil added DX Issues and PRs aimed at improving Developer eXperience. Do not stale Important issues and PRs, that should not be stalled by Stale Bot labels Jul 23, 2018
@pamil
Copy link
Contributor

pamil commented Jul 23, 2018

It's still a pain point from maintainer/contributor perspective.

@Zales0123
Copy link
Member

Zales0123 commented Dec 22, 2021

Even though we will probably be thinking about what we should do with Sylius-Standard in the future, I believe this issue can be closed 🖖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not stale Important issues and PRs, that should not be stalled by Stale Bot DX Issues and PRs aimed at improving Developer eXperience. RFC Discussions about potential changes or new features.
Projects
None yet
Development

No branches or pull requests

3 participants